scripts/shape_materialize.py: adopt_makefile_block's docstring says the block goes to the assembly root's Makefile, but where the source keeps a Makefile it goes to shape/Makefile (follow-up of #1061)

(2026-10-21T15:35:07Z, lane openRepoShape-1)

Found by: r1123, lane 1's independent review of #1123 (#1061). #1123's body had left this to #1048, but #1048's boxes and its PR #1105 do not hold it, so it is filed here.

scripts/shape_materialize.py adopt_makefile_block (about line 1140). The docstring says the block is appended to "the assembly root's Makefile". execute passes append={"Makefile": adopt_makefile_block(...)}, so the block goes wherever place writes the shape's Makefile: at the root, or at shape/Makefile where the source keeps a Makefile of its own (adopt-project.py: five printed sentences say what the run does not do: the Makefile follow-up beside a root Makefile, the contracts/-only read-across path, execute would stop there, a path names no attribute, and WHAT WILL HAPPEN under --local-remote-dir #906, adopt-project.py: a kept lower-case makefile or GNUmakefile still gets "the root Makefile wires CONTRACTS_DIR", and README.md's CONTRACTS_DIR sentence has no kept-Makefile case (follow-ups to #906) #977, adopt-project.py, README.md and tests: three follow-ups of PR #1046 (#977) from its review: a kept makefile/ row no test asks (mutant R10), README's make sentence that leaves out a kept GNUmakefile or makefile, and an older CONTRACTS_DIR docstring #1061). The docstring should say so.
- The materializer's readers (test_update_shape_add, test_family_makefile_siblings, test_neutral_pin_entry_one_spelling, test_update_shape_unreadable, test_adopt_leg_path_collisions) read this file as text, so they belong in the gate.

It is outside v1.2.0 by Brett Heap's ruling of 2026-10-21T10:32:04Z ("leave the follow-ups out of v1.2.0").

Lane: openreposhape-1 (openRepoShape-1)

CLAIMED — lane openRepoShape-1, session 300f8f46-004a-4e72-8587-4f192be2e108@Eagle, 2026-10-22T12:20:36Z, for #1135

Logged in lanes/log/openRepoShape-1.md at bbb9bb9154a818d43669485d16d0038d901cee7c.

The three reads (lane-collision-protocol Rule 1):

1. existing `CLAIMED —` comments on opensoft/openRepoShape#1135:
   none
2. `gh pr list --repo opensoft/openRepoShape --state all --search "#1135"`, kept where the row or its body names `#1135`:
1123	README.md, adopt-project.py and the handbook: a kept directory entry `makefile/` is tested, README says `make` at the root reads a kept `GNUmakefile` or `makefile` instead, and a docstring says the shape's Makefile alone holds `CONTRACTS_DIR` (#1061)	fix/1061-makefile-follow-ups	OPEN
3. `git ls-remote --heads git@github.com:opensoft/openRepoShape` branches naming `1135` as a whole token:
   none

Navigation Menu

Repository navigation

scripts/shape_materialize.py: adopt_makefile_block's docstring says the block goes to the assembly root's Makefile, but where the source keeps a Makefile it goes to shape/Makefile (follow-up of #1061) #1135

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

scripts/shape_materialize.py: adopt_makefile_block's docstring says the block goes to the assembly root's Makefile, but where the source keeps a Makefile it goes to shape/Makefile (follow-up of #1061) #1135

Description

Activity

brettheap commented on Oct 22, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions