adopt-project.py plan: an empty --id or --elected-by is read as not passed, and a derived id's refusal sends the person to an --id the naming policy then refuses #658

plan should refuse an empty passed --id or --elected-by by name, as --tracking-branch '' is since #479, and the derived-id refusal should say what to change, --project.

From the checklist triage of 2026-10-15, batch 3; Brett Heap approved its recommendations at 2026-10-16T12:14:51Z. One pull request covers the lines below.

Lands after: #620.

Decision applied: DB2 (option A) and DB3 (option 1).

Lines

Line numbers are at the commits named; main has moved since.

• L2-53: plan --id '' and plan --elected-by '' are read as not passed. Where: adopt-project.py _checked_plan_inputs, flags_given (:3273), args.id = args.id or args.project.lower() (:3309), args.elected_by = args.elected_by or _elector() (:3332); the contrast is given = args.tracking_branch is not None (:3279). Effort S; all. On main 396c0ff4: --id '' plans id: atlas and exits 0; --elected-by '' records the configured user.name and exits 0 though --help says "not blank"; with no user.name the refusal reads "--elected-by (not given, so git config user.name) is ''", naming "not given" for a flag that was passed; --tracking-branch '' is refused unsafe-value (probe l2-53-54.log).
• L2-54: for a derived id, "pass an explicit lowercase --id" leads to another refusal. Where: adopt-project.py:3309-3313 (derived at :3309, adopt-bad-id raised at :3311), _check_names at :3348, _refuse_another_repository called at :3321 and defined at :10166. Effort S; all. On main 396c0ff4: --project North_Wind gives REFUSED adopt-bad-id: --id 'north_wind' must match ...; adding --id north-wind gives REFUSED naming-unclassified: 'North_Wind' matches no family in the naming policy; for a source adopted in place (origin testorg/North_Wind) the second refusal says it cannot be adopted in place under that name and to rename it first (probe l2-54-inplace.log).

Rides along (backlog; tick it here if the same change covers it)

• L1-39, lane 1's line on Tracking: adopt-project.py, converting an existing repository in place #457, sent here from adopt-project.py: adopt-bad-id names an id derived from --project as derived, so --project North_Wind no longer says --id 'north_wind' must match over a flag nobody passed (#601) #620 by lane 1's D7 (D7 sent it to adopt-project.py: adopt-bad-id names an id derived from --project as derived, so --project North_Wind no longer says --id 'north_wind' must match over a flag nobody passed (#601) #620's next round, #601, comment, and adopt-project.py: adopt-bad-id names an id derived from --project as derived, so --project North_Wind no longer says --id 'north_wind' must match over a flag nobody passed (#601) #620 lands without one). In lane 1's words: "adopt-manifest-invalid names a filled-in --org as a flag (an org from a url that checked_value accepts but validate-manifest.py refuses, such as ~x), the mechanism lane 3's adopt-project.py plan: with no --elected-by and no user.name, the refusal reads --elected-by is '', naming a flag that was never passed #529 fixed for --elected-by (landed as adopt-project.py: plan names an elector it took from git config user.name by where it came from, so with no --elected-by and no git config user.name the refusal reads --elected-by (not given, so git config user.name) is '' and no longer --elected-by is '', a flag nobody passed (#529) #567); an org entry in FLAG_DEFAULTS is the cheap fix. Measured on 182389e. (Found in adopt-project.py and shape-doctor.py: one reading of origin, so a local clone's right --org is no longer refused, a url ending / names its repository, and the doctor's adoption line asks for --org wherever plan reads none (#521, #427) #591's writer and review.)" Where: adopt-project.py FLAG_DEFAULTS (:2663 on main 7ba64f01, as lane 1's D7 read it), the same table L2-54's derived-id label is built from. This line is lane 1's: lane 2 does not edit lane 1's comment, so lane 1 may mark it → this issue on Tracking: adopt-project.py, converting an existing repository in place #457 and tick it there when this closes. (source)

Notes for whoever takes it. #620's _refuse_bad_id (4c049a8, :3050-3065) builds the derived sentence by hand and, per rv601's probe P4, says "(--id was not given)" for --project North_Wind --id ''; the fix replaces that with FLAG_DEFAULTS["id"] (:2623) through _flag_named (:2819), as L2-54's direction says. L2-53 moves flags_given, which also labels the elector (:3331) and _flag_fields (:2831), so those labels' tests move with it. The mutant id_passed = args.id is not None survives every test of #620 because nothing tests --id ''; the fix adds that row. Not a duplicate of #261 (a blank ' '), #529 (the elector's label) or #420 (the branch alphabet).

Each line above is marked → this issue on its tracking issue. Tick it there too when this closes.