adopt-project.py check: a plan in a name the policy refuses gets no rename-first remedy, and a source that names no repository is never compared with the plan's recorded source.repository #716

adopt-project.py check should say, for a plan in the source's own refused name, what execute says on the same plan: rename the source first. And a plan whose recorded source: repository: was hand-edited should not check plan ok where the live source names no repository. The comment rider ties the two together.

From lane 4's checklist triage of 2026-10-16 (T6), approved by Brett Heap at 2026-10-16T13:36:07Z ("approve all triage recommendations"). One pull request covers the lines below.

Parent: #457. Milestone: v1.1.1 (a follow-up filed after Brett Heap's v1.1.1 word of 2026-10-16T13:35:28Z).

Authored after the v1.1.0 work; lands after the v1.1.0 tag unless the release owner (lane 3) says otherwise.

Lands after: every open change to adopt-project.py, because the file moves under it. Lane 4 merge-trees at each push, and the one that lands second re-gates:

• lane 2's adopt-project.py plan: an empty --id or --elected-by is read as not passed, and a derived id's refusal sends the person to an --id the naming policy then refuses #658 (filed, v1.1.0), whose pull request is adopt-project.py: plan refuses --id '' and --elected-by '' by name, a derived id's refusal says to change --project, or in place to rename the source first, and an org read from a url is named as not given (#658) #699;
• lane 3's README, AGENTS.md, docs/cli.md and the handbook: pipx install openreposhape is the second way in and the first on native Windows, git-filter-repo is installed in install.sh's order and never with a bare pip install, and a first draft of the v1.1.0 release notes (#563) #630 (a draft pull request; adopt-project.py's filter-repo-missing);
• lane 1's claimed adopt-project.py: a --work-dir that is a file or cannot be made ends plan, check and execute in a traceback, and --help says nothing of --work-dir or of where --org comes from #650, adopt-project.py and scaffold-project.py: a --pin naming an annotated tag's object id is written as the pin's commit:, under the pin file's "A COMMIT, NEVER A TAG" #651, adopt-project.py: --source <org/repo> reads a directory of that name under the current one, a trailing / clones into source-readonly/ itself, and a recorded clone that is gone or emptied is refused for the wrong reason #652, adopt-project.py under LC_ALL=C PYTHONUTF8=0: the --description em dash, plan's git grep and check's submodule url still end in a UnicodeEncodeError before any leg #653, adopt-project.py check: a kept or moved file other than .gitattributes whose blob git add would re-encode passes, and execute ends adopt-lost or dies mounting the legs after both legs are pushed #654, adopt-project.py and shape-doctor.py: a plan answer that overrides a confident rule passes check and execute, then the doctor's first run says MISPLACED, and an emptied .gitmodules is asked on every run #655, adopt-project.py check passes a source whose tree holds a symlink whose target begins with a NUL byte (\0spec.md, a 120000 blob of size 8), so with symlinks on execute creates both leg repositories and then fails cloning the source, exit 2 with nothing on stderr, and #303's plan-empty-symlink, which tests the blob's size, does not find it #388, adopt-project.py _verify never asks whether the split's root project.yaml is the shape's manifest, so the one refusal #305 added before any leg exists is all that keeps the source's own file out of the root, and a plan that gets past it ends adoption verified over an assembly shape-doctor.py calls NOT A SHAPE ROOT, where #165's gitlink checks in the same function fail closed #389, adopt-project.py check takes no --local-remote-dir and resolves a relative submodule url from GitHub's remotes, while execute --local-remote-dir resolves it from the bare repositories it creates, so under that test path check refuses an adoption execute verifies and passes one execute refuses #417 and adopt-project.py _default_branch reads the source's branch name through git_out, which decodes strictly, so a source whose HEAD (or origin/HEAD) names a branch that is not UTF-8 ends plan, check and execute in a UnicodeDecodeError traceback, exit 1, from Source.open, with no plan written and no refusal naming the branch #425 (no pull request open yet), all adopt-project.py;
• lane 2's adopt-project.py and scaffold-project.py: the Free-plan secrets hint goes by the assembly root's own visibility on GitHub and names the root as its reason, so a public source adopted with private legs is no longer told its organisation secrets resolve to EMPTY (#602) #621 has landed (4ce9045) and is not waited for.

Effort: S. Platform: all.

Files: adopt-project.py only; not a pinned shape copy, so no re-pin.

Lane openRepoShape-4 claims it at filing; see its CLAIMED comment.

Why this is filed. Both lines are pre-existing and exotic: a hand-edited plan in a name the policy refuses, and a hand-edited source: repository: on a source with no origin. execute refuses both, so nothing is lost; check is the command that tells a person before the legs exist. Line numbers are at c6122e8 (#639) unless a line says another commit; main has moved since (#621 and #627 landed).

Lines

• L4-38 (P3): adopt-project.py check gives no remediation for a plan in the source's own refused name: it calls _check_names without the source and prints only the detail, so a hand-edited billing-service plan whose origin is acme/billing-service gets naming-unclassified with no rename-first text (execute on the same plan does say it). Pre-existing: check prints no naming remediation at all. Where: adopt-project.py:8337 in cmd_check (:8276) calls _check_names(naming, names, pins) with no source, so no rename-first text (:8338 on 8062810d). (source)
• L4-40 (P3): when the live source names no repository, the plan's own recorded source: repository: is not consulted: a plan for acme/Atlas hand-edited to Atlsa, then git remote remove origin on the source, checks plan ok and execute reads https://github.com/acme/Atlsa.git. The same with execute --source <a copy with no origin>. Where: adopt-project.py:11477-11479, _not_the_source returns None where the live source names no repository (def _not_the_source is at :11531 on 8062810d); open_source (:4177) opens an existing local_path and never reads source.repository. (source)

Rides along (backlog; tick it here if the same change covers it)

• L4-48: adopt-project.py's comments on adopt-project.py plan never compares --project (or --org) with the repository it adopts in place, so a source named billing-service is refused with a remediation that steers to --project BillingService, which plans and checks plan ok against acme/billing-service, and execute then acts on acme/BillingService: a raw git ls-remote failure when no such repository exists, and, when a different repository of that name does, both legs, the split branch, the pull request and the topic on that repository #499's org: read overstate (adopt-project.py:7791 "a hand edit is caught too, whatever org: then holds, because it is read as execute reads it", and _not_the_source's docstring at :7920 "whatever the file holds"). An org: that checked_value itself refuses (a list, a mapping, an empty value, a space, a leading -, non-ASCII) is refused as unsafe-value by check, as on main, and is never compared as a repository. Comment wording only: the edit is still caught. On c6122e8 they are :11335 ("whatever org: then holds") and _not_the_source's docstring (:11463-11476, "whatever the file holds"); on 8062810d, :11403 and :11531. (From W513b's re-read of adopt-project.py: --org and --project must name the repository the source names, compared without case, so plan refuses --project BillingService for acme/billing-service as adopt-not-the-source instead of writing a plan whose execute acts on acme/BillingService, check finds and execute refuses a plan edited to name another as plan-not-the-source, and a source whose own name the naming policy refuses is told to rename it first, never to retype --project (#499) #513's body at 6b622c9.) (source)

What is expected

• check prints the rename-first text for a plan in the source's own refused name, as execute does: the source is handed to _check_names at the cmd_check site, and a test pins that check and execute say the same remedy on the same plan.
• A recorded source: repository: is compared with the source whenever the live source names none, so a hand edit of it is plan-not-the-source, in check and in execute. A test hand-edits a plan to Atlsa and removes origin, as the line measures it.
• L4-48: the two comments say what check does with an org: that checked_value refuses.

Not a duplicate: lane 2's #658 and #620 are the derived-id label; lane 1's #650 to #655 are other adopt-project.py lines. No issue numbered #650 to #700 cites L4-38, L4-40 or L4-48 (read at 13:17Z). L4-127, which sat with these lines in the first draft, is in #708: it is a regression from #644.

Each line above is a line of #457's checklist comment (issuecomment-6157842287). Tick it there too when this closes.

Lane: openreposhape-4 (openRepoShape-4)