Skip to content

tidb-cloud: fix reversed rows in the Parquet supported data types table - #24445

Open
mjonss wants to merge 1 commit into
pingcap:masterfrom
mjonss:fix-parquet-data-types-table
Open

mjonss wants to merge 1 commit into
pingcap:masterfrom
mjonss:fix-parquet-data-types-table

Conversation

@mjonss

@mjonss mjonss commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

What is changed, added, or deleted? (Required)

In the Supported data types table of tidb-cloud/import-parquet-files-serverless.md and tidb-cloud/import-parquet-files.md, the last four rows had the Parquet primitive type and the TiDB/MySQL type reversed (for example, | SMALLINT | N/A | INT32 |), which suggested that INT32 is a TiDB or MySQL type.

This PR removes these four rows and adds SMALLINT, SMALLINT UNSIGNED, TINYINT, and TINYINT UNSIGNED to the existing INT32 | N/A row.

Close #24444

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated the Parquet type mapping tables for standard and serverless imports. They now show INT32 values without a logical type mapping to INT, MEDIUMINT, SMALLINT, SMALLINT UNSIGNED, TINYINT, TINYINT UNSIGNED, and YEAR where applicable.

The last four rows of the "Supported data types" table had the Parquet
primitive type and the TiDB/MySQL type swapped (for example,
"| SMALLINT | N/A | INT32 |"). Move SMALLINT, SMALLINT UNSIGNED, TINYINT,
and TINYINT UNSIGNED into the existing "INT32 | N/A" row instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mjonss mjonss added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Oct 13, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2026
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: pingcap/docs/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c3c4c721-2960-4182-a3ae-2525126e68a1
📥 Commits

Reviewing files that changed from the base of the PR and between a0a22ca and fd7bf51.

📒 Files selected for processing (2)
  • tidb-cloud/import-parquet-files-serverless.md
  • tidb-cloud/import-parquet-files.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Both Parquet import guides now list SMALLINT, SMALLINT UNSIGNED, TINYINT, and TINYINT UNSIGNED under the INT32 mapping with no logical type. The four rows with reversed columns were removed.

Changes: Parquet type mapping

Layer / File(s) Summary
Update INT32 mapping tables
tidb-cloud/import-parquet-files-serverless.md, tidb-cloud/import-parquet-files.md
Both guides add four integer types to the INT32 mapping with no logical type. Both remove the four rows that placed these types in the Parquet primitive type column.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to fd7bf

The import guides now show the requested INT32 mapping, consistent with the unchanged export guide. No merge-blocking risk is evident.

### Architecture Summary

Architecture risk: 🔵 Low · up to fd7bf

The change affects 1 system.

Changed systems: tidb-cloud

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — tidb-cloud (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in tidb-cloud/import-parquet-files-serverless.md: The INT32/N/A mapping now includes SMALLINT, SMALLINT UNSIGNED, TINYINT, and TINYINT UNSIGNED. The four rows mapping these types to Parquet INT32 were removed; the other displayed mappings are unchanged.
  • observed — Modified behavior in tidb-cloud/import-parquet-files.md: The INT32/N/A mapping now includes SMALLINT, SMALLINT UNSIGNED, TINYINT, and TINYINT UNSIGNED alongside the previously listed integer types. The table removes four rows that listed those types as Parquet primitive types mapping to INT32.
Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Title check Passed The title clearly identifies the main change: correcting reversed rows in the Parquet supported data types table.
Description check Passed The description explains the changes, affected files, reason for the correction, applicable versions, reference link, AI involvement, and issue number. Required sections are substantially complete.
Linked Issues check Passed Issue #24444 requires correction of the Supported data types tables in both Parquet import documents. The diff updates both files. Each INT32 | N/A row now includes SMALLINT, SMALLINT UNSIGNED, …
Out of Scope Changes check Passed The diff changes only the two files named in issue #24444. All changes update the specified Supported data types tables. No unrelated source, configuration, or documentation changes are present.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tidb-cloud This PR relates to the area of TiDB Cloud. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tidb-cloud: columns reversed for SMALLINT/TINYINT rows in the Parquet supported data types table

1 participant