Skip to content

statistics: support dump/load/gc extended statistics - #19260

Merged
ti-srebot merged 3 commits into
pingcap:masterfrom
eurekaka:dump_load_gc
Sep 22, 2020
Merged

ti-srebot merged 3 commits into
pingcap:masterfrom
eurekaka:dump_load_gc

Conversation

@eurekaka

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Third TiDB PR for #18330

Parser PR: pingcap/parser#913, merged.
CREATE / DROP / RELOAD extended stats PR: #18880, merged.
Compute extended stats in ANALYZE: #19134, merged.

Problem Summary:

Not a problem, this is a new feature to support extended statistics for column groups.

What is changed and how it works?

What's Changed:

Support dump / load / gc for extended stats.

Related changes

  • Subsequent PRs would compute row count of plans using the extended stats

Check List

Tests

  • Unit test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • support dump / load / gc for extended stats

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/statistics component/executor labels Aug 18, 2020
@eurekaka
eurekaka requested a review from a team as a code owner August 18, 2020 08:53
@eurekaka
eurekaka requested review from SunRunAway and removed request for a team August 18, 2020 08:53
@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-check_dev_2
/run-unit-test

@eurekaka
eurekaka requested review from qw4990 and winoros and removed request for SunRunAway August 18, 2020 09:12

@winoros winoros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 17, 2020
@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-check_dev_2

@qw4990 qw4990 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 22, 2020
@qw4990

qw4990 commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2020
@ti-srebot

Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot
ti-srebot merged commit c303b05 into pingcap:master Sep 22, 2020
@eurekaka
eurekaka deleted the dump_load_gc branch September 23, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/executor component/statistics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants