Skip to content

planner: estimate index row count using extended correlation stats - #20160

Merged
eurekaka merged 3 commits into
pingcap:masterfrom
eurekaka:utilize_corr
Oct 12, 2020
Merged

eurekaka merged 3 commits into
pingcap:masterfrom
eurekaka:utilize_corr

Conversation

@eurekaka

@eurekaka eurekaka commented Sep 23, 2020 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Forth TiDB PR for #18330

Parser PR: pingcap/parser#913, merged.
CREATE / DROP / RELOAD extended stats PR: #18880, merged.
Compute extended stats in ANALYZE: #19134, merged.
Dump / load / GC extended stats PR: #19260, merged.

Problem Summary:

Not a problem, this PR improves index row count estimation by using extended stats.

What is changed and how it works?

What's Changed:

  • consider correlation when estimating row count for index scan with limit clause.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Estimate index row count using extended correlation stats

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner labels Sep 23, 2020
@eurekaka
eurekaka requested a review from a team as a code owner September 23, 2020 03:19
@eurekaka
eurekaka requested review from winoros and removed request for a team September 23, 2020 03:19
@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-all-tests

@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-tics-test

@winoros winoros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Comment thread planner/core/testdata/analyze_suite_in.json Outdated
@winoros
winoros requested a review from qw4990 September 23, 2020 17:08
@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-check_dev_2

@eurekaka
eurekaka requested a review from winoros September 25, 2020 09:55

@winoros winoros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 27, 2020

@lzmhhh123 lzmhhh123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 12, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 12, 2020
@lzmhhh123

Copy link
Copy Markdown
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2020
@ti-srebot

Copy link
Copy Markdown
Contributor

/run-all-tests

@ti-srebot

Copy link
Copy Markdown
Contributor

@eurekaka merge failed.

@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-unit-test

@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-all-tests

@eurekaka

Copy link
Copy Markdown
Contributor Author

/run-integration-common-test
/run-tics-test
/run-unit-test

@eurekaka
eurekaka merged commit ced01b2 into pingcap:master Oct 12, 2020
@eurekaka
eurekaka deleted the utilize_corr branch October 12, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants