refactor(client): share tool outcome rules

[t3dotgg]

Web and mobile repeat the rules for tool status, failure output, and success markers. Each fix has to stay in sync across both clients.

Move those rules into the existing shared work-log module. Keep each client's row visibility and grouping unchanged. Preserve web's output-only error check and the legacy check for activities that stored output in the command field. Both clients now use the same task-status mapping, including resumable idle tasks.

Verified with 351 focused tests across shared presentation, web session logic and timeline logic, and the mobile thread feed. Client-runtime, web, and mobile typechecks pass. Targeted lint and formatting pass. No browser or native runtime check was run for this refactor.

Created with GPT-6 Astra in Codex.

Note

Share tool outcome classification rules across web and mobile clients

• Adds shared work-log presentation predicates in client-runtime for tool-like detection, failure classification, success classification, and lifecycle status mapping
• Removes duplicate web-local and mobile-local implementations in session-logic.ts and threadActivity.ts; both now import from the shared module
• The shared status mapper normalizes waiting to inProgress, cancelled and interrupted to stopped, and subagent-batch idle to stopped
• Adds a display-specific failure predicate that ignores error-like text appearing only in the command field, separate from the legacy command-inclusive predicate
• Behavioral Change: extractWorkLogToolLifecycleStatus in client-runtime now maps previously unrecognized waiting, cancelled, interrupted, and subagent-batch idle statuses; web work-log derivation will classify these rows differently than before (e.g. waiting rows now show as active instead of being ignored)

^{Macroscope summarized dcd4345.}

[macroscopeapp]

Approvability

Verdict: Approved at be0495d

Macroscope's review found this PR approvable — This is a contained client-runtime refactor that centralizes existing tool outcome rules for web and mobile, with focused coverage for the lifecycle statuses whose work-log presentation changes. Its runtime impact is limited to localized tool-row visibility and status markers, with no schema, execution, infrastructure, security, billing, or default-behavior changes.

No code changes detected at dcd4345. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.5 KiB	13.5 KiB	+13 B (+0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−9 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+22 B (+0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.0 KiB	57.0 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	8	8	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.5 KiB	−39 B (−0.3%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+3 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.5 KiB	−42 B (−0.6%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	57.8 KiB	−88 B (−0.1%)	66.4 KiB	✅
Claude	Live turn messages	10	8	−2 (−20.0%)	21	✅

Baseline: 7544d3d · PR result: dcd4345 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Dismissing prior approval to re-evaluate be0495d