[juliusmarminge]

gitHubChangeRequestTemplate.ts listed only the uppercase PULL_REQUEST_TEMPLATE spellings in TEMPLATE_DIRECTORIES. Both the ls-tree pathspec and the readTemplateDirectory prefix check are case-sensitive, so a lowercase pull_request_template/ directory (in .github/, the repository root or docs/) was never listed, no template reached buildPrContentPrompt, and PR generation used the generic Summary/Testing layout. The fix adds the lowercase spelling right after each uppercase one. This follows the existing TEMPLATE_PATHS pattern, which lists both spellings. Location precedence (.github, then root, then docs) and the existing Ambiguous handling are unchanged. No new regex or parser was added.

Fixes #35204

Reproduction on main

On origin/main f419698, I added three lowercase rows (.github/pull_request_template, pull_request_template, docs/pull_request_template) to the existing it.effect.each(TEMPLATE_DIRECTORIES) 'recognizes the $0 directory' table in packages/source-control-github/src/server/gitHubChangeRequestTemplate.test.ts. Each row commits

/template.MD with the text 'directory template' to a fresh repository and calls the production detect(cwd, 'HEAD', git.execute) with real git subprocesses. Ran vp test run packages/source-control-github/src/server/gitHubChangeRequestTemplate.test.ts: 3 failed, 15 passed. The three lowercase-directory rows failed with 'expected undefined to equal "directory template"' and the uppercase PULL_REQUEST_TEMPLATE rows passed. Full PR creation through the app was not run: it needs a live model and a real PR, and detect is the only step that decides whether a template reaches the prompt builder.

Evidence

Both commits ran with fresh databases and the same synthetic repository in Chromium 156 at 1280 × 800, light theme. With Follow change request templates enabled, commit one .github/pull_request_template/feature.md template containing Change details / Verification evidence headings, commit a greeting change on a feature branch, then click Create PR. The real writer generated each description. A local GitHub fixture intercepted submission, and the app terminal displays the exact outgoing body. No PR was published.

Before	After
f419698aea	9dcbb1db2f

Before recording · After recording

Scenario · Reproduction helpers and sanitized diagnostics · Before body · After body

AI-assisted; verified with the tests and tools listed above.

Not shown:

• Publication and GitHub-hosted rendering were not exercised: the final submission was intercepted locally to avoid creating a public PR.
• The additional lowercase directory locations at the repository root and under docs/ were not captured; this comparison covers .github/pull_request_template/feature.md.

Tests

vp test run packages/source-control-github/src/server/gitHubChangeRequestTemplate.test.ts: before the fix 3 failed, 15 passed (the three lowercase directory rows from factory/repro-35204); after the fix 18 passed. vp run check:changed: format, lint, knip, graphql, typecheck (11 packages) and tests (2 files) all passed.

Not in this change

• Mixed-case directory spellings (e.g. Pull_Request_Template/) are still not matched; single template files are matched in any casing via git grep icase, but making directories fully case-insensitive would need a different listing approach.

AI-assisted; verified with the tests and tools listed above.

[macroscopeapp]

Approvability

Verdict: Approved at 9dcbb1d

Macroscope's review found this PR approvable — Recognizes PR templates in lowercase directories at the existing supported repository locations. Existing template-reading safeguards remain unchanged, and the effect is limited to generated PR content.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	21.5 KiB	21.5 KiB	0 B (0.0%)	24.4 KiB	✅
Codex	Live turn messages	1	1	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.9 KiB	21.9 KiB	0 B (0.0%)	24.4 KiB	✅
Claude	Live turn messages	1	1	0 (0.0%)	8	✅

Baseline: f419698 · PR result: 9dcbb1d · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The template detector now recognizes lowercase PR template directories at the repository root, under .github, and under docs. Tests cover the added directory paths. Existing uppercase paths remain.

Changes: PR template detection

Layer / File(s)	Summary
Directory matching and test coverage packages/source-control-github/src/server/gitHubChangeRequestTemplate.ts, packages/source-control-github/src/server/gitHubChangeRequestTemplate.test.ts	TEMPLATE_DIRECTORIES includes lowercase variants of the root, .github, and docs template directories. The directory-recognition tests cover those paths.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

• pingdotgg/t3code#21449: Updates the same template discovery logic and adds coverage for directory case variants.
• pingdotgg/t3code#25025: Updates matching for differently cased template paths in the same discovery logic.

Suggested labels: bugfix, size:XS

Suggested reviewers: macroscopeapp, maria-rcks

Merge Risk: Minimal · up to 9dcbb

Lowercase pull_request_template directories will now be recognized for PR description generation. The change is small, existing precedence is unchanged, and no merge-blocking risk is identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: lowercase pull_request_template directories are now found for PR templates. It matches the diff, which adds lowercase TEMPLATE_DIRECTORIES entries, and it also names t…
Linked Issues check		[#35204] Requires the detector to recognize a single usable template in lowercase pull_request_template/ directories at the repository root, under .github/, and under docs/. At the reviewed head, TEMP…
Out of Scope Changes check		The source change adds three string entries to TEMPLATE_DIRECTORIES. Each entry is the lowercase spelling of an existing uppercase entry, and the change follows the existing TEMPLATE_PATHS pattern. Th…
Description check		The description follows the repository's template in substance. It has Problem, Change, Scope, and Verification content. The Problem section explains the case-sensitive listing bug and the resulting g…

Full details: Title check

Explanation

The title names the main change: lowercase pull_request_template directories are now found for PR templates. It matches the diff, which adds lowercase TEMPLATE_DIRECTORIES entries, and it also names the github scope. The title is 83 characters, which is long, but it is still a single clear sentence.

Full details: Linked Issues check

Explanation

[#35204] Requires the detector to recognize a single usable template in lowercase pull_request_template/ directories at the repository root, under .github/, and under docs/. At the reviewed head, TEMPLATE_DIRECTORIES in gitHubChangeRequestTemplate.ts includes '.github/pull_request_template', 'pull_request_template', and 'docs/pull_request_template'. The ls-tree call passes TEMPLATE_DIRECTORIES as pathspecs, so these directories are listed. readTemplateDirectory then matches entries under the lowercase prefix, so a single .md or .txt file in those directories is returned as the template. Precedence is preserved: single-file candidates are read before the directory loop. Ambiguity is preserved: a second usable file in one directory returns Ambiguous, which yields Option.none(). The detected template flows through detect() to the caller that builds the PR prompt. The test table in gitHubChangeRequestTemplate.test.ts adds the three lowercase rows, and the PR reports 18 passing tests after the fix (3 failing before). I did not inspect the test diff directly. Mixed-case directory names remain unmatched, which the issue does not require. Live PR generation was not verified, as stated in the PR description.

Full details: Out of Scope Changes check

Explanation

The source change adds three string entries to TEMPLATE_DIRECTORIES. Each entry is the lowercase spelling of an existing uppercase entry, and the change follows the existing TEMPLATE_PATHS pattern. The test file change adds rows to the existing directory detection table for the same three paths. The PR description states that location precedence, ambiguity handling, and the grep and ls-tree logic are unchanged, and the diff confirms no other code changed in the source file. No unrelated changes were found in the reviewed source diff. The raw summary lists no other changed files.

Full details: Description check

Explanation

The description follows the repository's template in substance. It has Problem, Change, Scope, and Verification content. The Problem section explains the case-sensitive listing bug and the resulting generic PR layout. The Change section describes the lowercase directory entries and states that precedence and Ambiguous handling are unchanged. The Scope section links issue #35204 (fixes #35204) as the bug report. The Verification section gives a before/after focused test run (3 failed/15 passed, then 18 passed), a repo check run, and app before/after evidence with screenshots and recordings. It also states what was not checked: publication, GitHub-hosted rendering, and root/docs directory captures. The template's required model/harness line is not present as a closing attribution; the description says 'AI-assisted' but does not name the model and harness. The description also includes a 'Not in this change' section, which is extra but harmless. The description is largely complete and well-supported.

Finishing Touches

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: factory/issue-35204
• File: .coderabbit.config.ts
• Commit: 9dcbb1d
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Team
• Run ID: 2c0e766e-e75a-45c1-b0fd-a1cbfece4880

Commits

Reviewing files that changed from the base of the PR and between f419698 and 9dcbb1d.

Files selected for processing: 2

• packages/source-control-github/src/server/gitHubChangeRequestTemplate.test.ts
• packages/source-control-github/src/server/gitHubChangeRequestTemplate.ts

Limit details: You’ve used all 10 included reviews currently available.