You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): zoom shortcuts work while a desktop browser page has focus - #35947
Review item 1 was correct and is fixed. The previous head forwarded preview.zoomIn, zoomOut and resetZoom out of a focused browser page desktop-first. beforeInput called event.preventDefault() on mod+=, mod++, mod+- and mod+0, so the guest page never saw those keydowns and pages that use them for their own zoom (Figma, Excalidraw, Sheets) lost them; that was a regression against main. This commit adds the three commands to PAGE_FIRST_FORWARDED_COMMANDS in apps/desktop/src/preview/Manager.ts, the path #22960 added for preview.find. beforeInput leaves these keys to the page, and the main-frame preload (PickPreload reportUnhandledShortcut, which already reports any Cmd/Ctrl/Alt chord the page did not preventDefault) tells the host about an unhandled one. Only then is it forwarded as a menu action, which PreviewView maps to the browser panel's zoom. The earlier commit's forwarding-list and PreviewView changes are kept, so on a plain page Cmd/Ctrl+=/-/0 still zoom the panel. As with find, auto-repeat is not forwarded on this path (the preload skips event.repeat), so holding a zoom key zooms once. No new regex or parser. Verified with unit tests only, not in the running desktop app.
Commit afff0d3 (origin/main). Ran the desktop app with T3CODE_DEV_SEED=0 vp run dev:desktop under headless-desktop (Xvfb, Linux). Finished onboarding, added an empty scratch folder as a project, opened the right panel's Browser surface and loaded a local static test page that prints window.devicePixelRatio. Drove input with real X11 events (xdotool). (1) Clicked inside the page: document.activeElement became the . Pressed Ctrl+= twice: the page stayed at devicePixelRatio=1 and the main app zoom also stayed at 1. Nothing happened. (2) Control: clicked the browser's address bar and pressed Ctrl+= twice: the page zoomed to devicePixelRatio=1.25. So the zoom shortcuts work only while focus is on the browser panel's own controls, as reported. Ctrl+- and Ctrl+0 go through the same forwarding list (code reading; only Ctrl+= was exercised live). A test asserting the zoom commands are forwarded fails on main.
Evidence
Real Electron desktop app on Linux/Xvfb, 1600×960, light theme, fresh isolated state and the same synthetic replay thread. Click inside the Browser page, then press Ctrl+= twice, Ctrl+- once, and Ctrl+0. Finally click the address bar and repeat zoom-in as a control. Recordings use real X11 input; captions identify each action.
The address-bar control reaches 125% on both commits. The main app remains at 100% throughout. Focus observations confirm WEBVIEW and guest focus during the page shortcuts.
macOS Cmd shortcuts were not exercised; this comparison used the reported Linux Ctrl reproduction.
Page-defined zoom handlers and focused iframes were not exercised; the fixture is a top-level page that never prevents keyboard events.
Tests
Ran from apps/desktop: vp test run src/preview/Manager.test.ts -t "claim the find" gave 3 passed (darwin, linux, win32) with the fix, and 3 failed with the Manager.ts change reverted, i.e. the zoom key was swallowed on the previous head. vp run check:changed passed: format, lint, knip, typecheck (3 packages), tests (3 files, including ReopenClosedViewShortcut.browser.test.tsx) and the react compiler check.
Not in this change
Did not exercise the fix live in the Electron desktop app under Xvfb; that is left to the proof step.
Did not exercise the fix live in the Electron desktop app; that is left to the proof step.
Holding a zoom key zooms once rather than repeating, because the page-first path skips repeats as it does for find; not changed.
Who did the work
Written by Claude Opus 5.5, in Claude Code
Reviewed by GPT-6.1 Sol, in Codex, and by Claude Opus 5.5, each on its own
Proof captured by GPT-6.1 Sol and checked by Claude Opus 5.5
Fails on main: preview.zoomIn, preview.zoomOut and preview.resetZoom are
not in the commands forwarded out of a focused browser page (#35926).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A focused browser-panel page swallows keydowns, and the desktop forwarded
only some preview chords out of it. Forward preview.zoomIn, zoomOut and
resetZoom too, and handle them as menu actions in PreviewView.
Fixes#35926
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…l zooms
Forwarded zoom chords were desktop-first, so the guest page never saw
Cmd/Ctrl+=, - or 0 and canvas apps lost their own zoom. Route them
through the page-first path used for find: the panel zooms only when the
page leaves the key unhandled.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Macroscope's review found this PR approvable — Restores zoom shortcuts while a desktop preview page has focus, using existing zoom handlers and preserving page-first shortcut handling. The change is limited to reversible preview presentation.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
The preview zoom-in, zoom-out, and reset-zoom commands now use the existing shortcut forwarding path. PreviewView also maps desktop menu actions for these commands to preview actions.
Changes: Preview zoom shortcut forwarding
Layer / File(s)
Summary
Forward zoom commands and handle menu actions apps/desktop/src/preview/Manager.ts, apps/desktop/src/preview/Manager.test.ts, apps/web/src/components/ReopenClosedViewShortcut.tsx, apps/web/src/components/ReopenClosedViewShortcut.browser.test.tsx, apps/web/src/components/preview/PreviewView.tsx
The desktop and web shortcut lists now include zoom in, zoom out, and reset zoom. PreviewView maps the corresponding desktop menu actions to preview actions. Tests cover page handling of zoom-in shortcuts and the forwarded command list.
pingdotgg/t3code#35164 — The PR adds zoom commands to the shortcut path, but does not change the draft-route gate identified in this issue. Whether zoom shortcuts are still dropped on draft routes is unverified.
Zoom shortcuts now reach the browser panel when a page has focus. Pages that handle zoom themselves keep that behavior. The change is small and reuses the existing page-first forwarding path, and no concrete merge-blocking risk was found. The author reports unit-test verification only, with no live check in the desktop app.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title, “fix(web): zoom shortcuts work while a desktop browser page has focus,” describes the main change. It follows the conventional commit format and is 68 characters long.
Linked Issues check
[#35926] requires Cmd/Ctrl+=, -, and 0 to zoom in, zoom out, or reset the browser panel when a page inside the browser has focus. At the reviewed head, Manager.ts adds preview.zoomIn, preview.zoomOut,…
Out of Scope Changes check
All changes relate to the zoom shortcut requirement of #35926. Manager.ts adds the three zoom commands to the page-first list and updates a comment about iframe zoom handling. PreviewView.tsx maps the…
Description check
The description covers the problem (zoom shortcuts swallowed when a desktop browser page has focus), the change (adding preview.zoomIn, zoomOut, and resetZoom to PAGE_FIRST_FORWARDED_COMMANDS in Manag…
Full details: Linked Issues check
Explanation
[#35926] requires Cmd/Ctrl+=, -, and 0 to zoom in, zoom out, or reset the browser panel when a page inside the browser has focus. At the reviewed head, Manager.ts adds preview.zoomIn, preview.zoomOut, and preview.resetZoom to PAGE_FIRST_FORWARDED_COMMANDS. The guest page therefore receives these keys first. If the page does not call preventDefault, the existing main-frame preload reports the chord and the host forwards it as a menu action. PreviewView.tsx maps preview.zoomIn, preview.zoomOut, and preview.resetZoom to onPreviewAction('zoom-in' | 'zoom-out' | 'reset-zoom'). This satisfies the issue's expected behavior for pages without their own zoom handling. The issue's suggested fix (forward the commands and map the menu actions) is also implemented. Unit tests in Manager.test.ts cover the forwarding, and the PR reports the test fails when Manager.ts is reverted. Limitations: auto-repeat is not forwarded, so holding a zoom key zooms once. The issue does not require repeat. Live verification in the Electron app was not performed; this is not a coding requirement.
Full details: Out of Scope Changes check
Explanation
All changes relate to the zoom shortcut requirement of #35926. Manager.ts adds the three zoom commands to the page-first list and updates a comment about iframe zoom handling. PreviewView.tsx maps the three menu actions to existing preview actions. ReopenClosedViewShortcut.tsx adds the three commands to PREVIEW_FORWARDED_COMMANDS. The browser test and Manager.test.ts updates verify these commands. No unrelated behavior change appears in the reviewed diffs for Manager.ts and PreviewView.tsx. The PR description contains a duplicated bullet in 'Not in this change', which is documentation only and not a code scope issue.
Full details: Description check
Explanation
The description covers the problem (zoom shortcuts swallowed when a desktop browser page has focus), the change (adding preview.zoomIn, zoomOut, and resetZoom to PAGE_FIRST_FORWARDED_COMMANDS in Manager.ts), scope (linked issue #35926, bug fix), and verification (unit tests run on three platforms, a before/after reproduction on main, and screenshots and recordings). It also notes what was not checked, such as macOS Cmd shortcuts and focused iframes. The template's Verification section asks for focused tests and observed results, and this description provides both. The description has minor redundancy, since the 'Did not exercise the fix live' point appears twice under 'Not in this change'. It also lists 'Who did the work' with model names, which the template asks for.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Limit details: You’ve used all 10 included reviews currently available. Your 26 included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.
Julius, here is what I had on #35926 before I stopped. I did not reproduce it live on any device, so this is mostly code reading.
Cause (code reading): the desktop forwards chords from a focused guest page through PREVIEW_FORWARDED_COMMANDS (apps/web/src/components/ReopenClosedViewShortcut.tsx). preview.zoomIn, preview.zoomOut and preview.resetZoom are not on that list, and PreviewView does not map their menu actions. This matches the issue. Your PR body's live repro on main covers the same ground.
My branch:issue-watch/35926 at 0c7f997ad16 adds the three commands to that list and maps them in PreviewView. Two browser tests are extended. I did not run them. Reading your PR, I think that version is the one you flagged: beforeInput prevents default on these chords before the page sees them, so pages that use mod+= for their own zoom would lose it. I did not verify that live. Your page-first approach is the one I'd keep.
Live runs: on Linux the dev desktop app got to the welcome screen, then the renderer crashed (exit 133) while loading t3code-dev:// modules on three launches. I stopped it and did not get a live result. Nothing on Linux is proven either way.
Still running when I stopped: a macOS run on shiv (base vs head, same steps) and a Codex review of 0c7f997. The review is waiting on a command approval. A Boat check of the same commit is queued behind Boat's start limit. I won't post again when they finish. Their results are not in this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 changed lines (additions + deletions).vouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Review item 1 was correct and is fixed. The previous head forwarded preview.zoomIn, zoomOut and resetZoom out of a focused browser page desktop-first. beforeInput called event.preventDefault() on mod+=, mod++, mod+- and mod+0, so the guest page never saw those keydowns and pages that use them for their own zoom (Figma, Excalidraw, Sheets) lost them; that was a regression against main. This commit adds the three commands to PAGE_FIRST_FORWARDED_COMMANDS in apps/desktop/src/preview/Manager.ts, the path #22960 added for preview.find. beforeInput leaves these keys to the page, and the main-frame preload (PickPreload reportUnhandledShortcut, which already reports any Cmd/Ctrl/Alt chord the page did not preventDefault) tells the host about an unhandled one. Only then is it forwarded as a menu action, which PreviewView maps to the browser panel's zoom. The earlier commit's forwarding-list and PreviewView changes are kept, so on a plain page Cmd/Ctrl+=/-/0 still zoom the panel. As with find, auto-repeat is not forwarded on this path (the preload skips event.repeat), so holding a zoom key zooms once. No new regex or parser. Verified with unit tests only, not in the running desktop app.
Fixes #35926
Reproduction on main
Commit afff0d3 (origin/main). Ran the desktop app with
T3CODE_DEV_SEED=0 vp run dev:desktopunder headless-desktop (Xvfb, Linux). Finished onboarding, added an empty scratch folder as a project, opened the right panel's Browser surface and loaded a local static test page that prints window.devicePixelRatio. Drove input with real X11 events (xdotool). (1) Clicked inside the page: document.activeElement became the . Pressed Ctrl+= twice: the page stayed at devicePixelRatio=1 and the main app zoom also stayed at 1. Nothing happened. (2) Control: clicked the browser's address bar and pressed Ctrl+= twice: the page zoomed to devicePixelRatio=1.25. So the zoom shortcuts work only while focus is on the browser panel's own controls, as reported. Ctrl+- and Ctrl+0 go through the same forwarding list (code reading; only Ctrl+= was exercised live). A test asserting the zoom commands are forwarded fails on main.Evidence
Real Electron desktop app on Linux/Xvfb, 1600×960, light theme, fresh isolated state and the same synthetic replay thread. Click inside the Browser page, then press Ctrl+= twice, Ctrl+- once, and Ctrl+0. Finally click the address bar and repeat zoom-in as a control. Recordings use real X11 input; captions identify each action.
The address-bar control reaches 125% on both commits. The main app remains at 100% throughout. Focus observations confirm WEBVIEW and guest focus during the page shortcuts.
Recording driver · Setup script · Static test page · Base observations · Head observations
Not shown:
Tests
Ran from apps/desktop: vp test run src/preview/Manager.test.ts -t "claim the find" gave 3 passed (darwin, linux, win32) with the fix, and 3 failed with the Manager.ts change reverted, i.e. the zoom key was swallowed on the previous head. vp run check:changed passed: format, lint, knip, typecheck (3 packages), tests (3 files, including ReopenClosedViewShortcut.browser.test.tsx) and the react compiler check.
Not in this change
Who did the work
Run by the t3code factory in T3 Code.