Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved a344b1a This is a simple, self-contained UI bug fix that adds standard Android text properties (maxLines, ellipsize) to properly handle text overflow in the collapsed composer hint view. The change has clear intent, limited scope, and no side effects beyond the intended visual improvement. You can customize Macroscope's approvability policy. Learn more. |
|
Would love to see it land |
Fixes reproduced on an Android emulator and from upstream reports. Feed: Android stops drawing a text view past the GPU's maximum texture height, so a long list rendered as one selectable Text lost its tail and took seconds per frame to draw. Long lists now split into 40-item chunks. Wide assistant markdown blocks keep a pinned width; the feed reserves bottom padding. Keyboard: the feed re-pins after keyboard transitions settle and when the composer collapses; the back gesture collapses the composer; sticky composers only follow the keyboard after a fresh show or real focus (upstream pingdotgg#8212). Terminal: hardware Enter no longer moves focus off the terminal; keyboards that use deleteSurroundingText (FUTO) send Backspace; forward delete works. Also: stream haptics no longer buzz every 320ms on Android and all haptics use the system engine; thread settings apply on tap without Save; typed pairing codes are normalized to the server format; non-git projects fall back to the current checkout instead of a dead worktree default; user CA certificates are trusted; Ctrl/Cmd+Enter sends from a hardware keyboard; thread rename, project favicons in the filter, tablet sidebar toggle, desktop-window density, route titles, Material You review colors, bottom gesture-bar insets, and the composer placeholder clipping (upstream PRs pingdotgg#11503, pingdotgg#11370, pingdotgg#11339, pingdotgg#8200, pingdotgg#8717, pingdotgg#11445, pingdotgg#6003, pingdotgg#5052, pingdotgg#8362, pingdotgg#10709, pingdotgg#11611, pingdotgg#8800, adapted).

What Changed
Why
On narrow Android screens, the collapsed composer placeholder could wrap onto a second line inside its fixed-height pill. The second line was clipped by the container. Keeping the native editor to one line in its existing
singleLineCenteredstate prevents the clipped text without changing expanded multiline editing.UI Changes
Before
After
Validation
:t3-composer-editor:compileDebugKotlin:app:assembleDebugChecklist
Note
[!NOTE]
Fix hint text clipping in collapsed mobile composer by restricting to single line with ellipsis
In T3ComposerEditorView.kt, the
setCenteredmethod now setsmaxLines = 1andellipsize = TextUtils.TruncateAt.ENDwhen the composer is in centered (collapsed) mode, truncating overflow text instead of clipping it. When not centered,maxLinesreverts toInt.MAX_VALUEand ellipsize is cleared.Macroscope summarized b57e616.
Note
Low Risk
Small, localized Android native UI change in collapsed composer layout only; no auth, data, or expanded-editor behavior changes.
Overview
Fixes clipped placeholder/hint text on narrow Android screens when the composer is collapsed in its fixed-height pill.
Android
T3ComposerEditorView:setSingleLineCenteredalready toggles vertical gravity; it now also setsmaxLines = 1andTextUtils.TruncateAt.ENDwhen centered (collapsed), and restoresInt.MAX_VALUElines with no ellipsize when expanded. Collapsed text stays on one line with trailing ellipsis instead of wrapping into a second line that the container clips.Expanded multiline editing behavior is unchanged.
Reviewed by Cursor Bugbot for commit b57e616. Bugbot is set up for automated code reviews on this repo. Configure here.
Closes #10860