Skip to content

fix(mobile): space project destination title - #8717

Open
jetpham wants to merge 1 commit into
pingdotgg:mainfrom
jetpham:t3code/fix-project-destination-spacing
Open

jetpham wants to merge 1 commit into
pingdotgg:mainfrom
jetpham:t3code/fix-project-destination-spacing

Conversation

@jetpham

@jetpham jetpham commented Aug 30, 2026

Copy link
Copy Markdown

Fixes #8735

What Changed

Adds an explicit Add Project Destination title to the mobile clone destination route.

Why

Without a display title, React Navigation falls back to the internal AddProjectDestination route name. Android renders that fallback literally in the native header.

Verification

  • Built and launched the development app on an Android 16 (API 36) emulator
  • Opened the project destination route and confirmed the native header reads Add Project Destination
  • vp run --filter @t3tools/mobile typecheck
  • git diff --check

UI Changes

Before After
Android project destination header showing the unspaced route name Android project destination header showing the readable title

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for the UI change
  • This change does not involve animation or interaction

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 49ac9b5a-16dd-4948-a3ca-cb80275cbda8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 30, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 1455acc

Macroscope's review found this PR approvable — This is a narrowly scoped mobile UI fix that gives an existing route an explicit spaced header title. It leaves navigation, linking, and underlying project-destination behavior unchanged.

You can add or adjust custom eligibility rules. Learn more.

Sowyu pushed a commit to Sowyu/t3pretzel that referenced this pull request Sep 15, 2026
Fixes reproduced on an Android emulator and from upstream reports.

Feed: Android stops drawing a text view past the GPU's maximum texture
height, so a long list rendered as one selectable Text lost its tail and
took seconds per frame to draw. Long lists now split into 40-item chunks.
Wide assistant markdown blocks keep a pinned width; the feed reserves
bottom padding.

Keyboard: the feed re-pins after keyboard transitions settle and when the
composer collapses; the back gesture collapses the composer; sticky
composers only follow the keyboard after a fresh show or real focus
(upstream pingdotgg#8212).

Terminal: hardware Enter no longer moves focus off the terminal; keyboards
that use deleteSurroundingText (FUTO) send Backspace; forward delete works.

Also: stream haptics no longer buzz every 320ms on Android and all haptics
use the system engine; thread settings apply on tap without Save; typed
pairing codes are normalized to the server format; non-git projects fall
back to the current checkout instead of a dead worktree default; user CA
certificates are trusted; Ctrl/Cmd+Enter sends from a hardware keyboard;
thread rename, project favicons in the filter, tablet sidebar toggle,
desktop-window density, route titles, Material You review colors, bottom
gesture-bar insets, and the composer placeholder clipping (upstream PRs
pingdotgg#11503, pingdotgg#11370, pingdotgg#11339, pingdotgg#8200, pingdotgg#8717, pingdotgg#11445, pingdotgg#6003, pingdotgg#5052, pingdotgg#8362, pingdotgg#10709,
pingdotgg#11611, pingdotgg#8800, adapted).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Android project destination header shows route name

1 participant