Skip to content

fix(web): pinned reorder no longer reshuffles while writes land - #5767

Merged
t3dotgg merged 1 commit into
mainfrom
t3code/fix-pinned-reorder-flicker
Aug 9, 2026
Merged

fix(web): pinned reorder no longer reshuffles while writes land#5767
t3dotgg merged 1 commit into
mainfrom
t3code/fix-pinned-reorder-flicker

Conversation

@t3dotgg

@t3dotgg t3dotgg commented Aug 9, 2026

Copy link
Copy Markdown
Member

Dragging a card in the pinned section landed in the right place eventually, but the block visibly shuffled around for a moment after the drop.

The sidebar already holds an optimistic order after a drop, but it released that override as soon as any pinOrderKey changed in canonical state. That is fine for the common single-key drop. When a neighbor has no key yet (threads pinned before reordering shipped), the drop rewrites every key in the section as several sequential writes — and the override released after the first one landed, exposing the half-written canonical order. The block then reshuffled once per remaining write.

The fix: the drop now remembers which keys it planned to write, and the override holds until all of them show up in canonical state. A key we did not write landing (a concurrent client reordering) still releases immediately so their write wins, and the existing membership-change and failure releases are unchanged. One small hardening: an interrupted write now also clears the override, since a key that never lands could otherwise hold it indefinitely.

No new state machinery — one extra field on the existing optimistic state and a tighter release condition.


🤖 Generated with Claude Code (Claude Fable 5)


Note

Low Risk
Localized sidebar DnD optimistic-state logic with no auth or data-model changes; behavior is easier to reason about and reduces visible UI flicker.

Overview
Fixes post-drop shuffling in the pinned sidebar block when a drag triggers full-section key materialization (neighbors without pinOrderKey).

The optimistic order override now stores assignedKeys from planPinnedReorder and stays active until every planned pinOrderKey appears in canonical state—not on the first key change. Foreign key updates (another client’s reorder) still drop the override immediately; membership changes and order confirmation behave as before.

Reorder failures (including interrupted commands) now always clear the override so a key that never lands cannot pin stale order indefinitely.

Reviewed by Cursor Bugbot for commit 6e87003. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pinned sidebar reorder to persist optimistic order until all writes land

  • The optimistic pinned order in Sidebar.tsx previously released too early during multi-key materialization, causing the list to reshuffle while writes were still in flight.
  • Adds an assignedKeys map to optimisticPinnedOrder tracking the exact order keys this client planned to write.
  • The release effect now waits until all assigned keys appear in canonical state (allAssignmentsLanded), and also releases early if a foreign (non-assigned) key lands or membership changes.
  • Interrupted write failures now clear the optimistic override silently; only non-interrupted failures show an error toast.
📊 Macroscope summarized 6e87003. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8efac7ad-8d49-45b8-b39c-4015ed2c1dd8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 9, 2026
);
if (result._tag === "Failure" && !isAtomCommandInterrupted(result)) {
if (result._tag === "Failure") {
// Any failure — interrupted included — releases the override:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium components/Sidebar.tsx:2428

When a pinned-thread reorder write fails or is interrupted, setOptimisticPinnedOrder(null) unconditionally clears the optimistic override — even when the override now belongs to a different, newer drop. If the user starts a second drag while the first drop's writes are still in flight, an interruption of the earlier write clears the newer drop's override, snapping the newer card back even though its own writes may still succeed. Consider tracking which drop the override belongs to (e.g. a token) and only clearing when the current override matches the failing operation.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/web/src/components/Sidebar.tsx around line 2428:

When a pinned-thread reorder write fails or is interrupted, `setOptimisticPinnedOrder(null)` unconditionally clears the optimistic override — even when the override now belongs to a *different*, newer drop. If the user starts a second drag while the first drop's writes are still in flight, an interruption of the earlier write clears the newer drop's override, snapping the newer card back even though its own writes may still succeed. Consider tracking which drop the override belongs to (e.g. a token) and only clearing when the current override matches the failing operation.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 11.3 KiB 11.3 KiB +3 B (+0.0%) 15.1 KiB
Codex Thread snapshot wire 5.5 KiB 5.5 KiB −3 B (−0.1%) 7.3 KiB
Codex Live turn WebSocket wire 5.9 KiB 5.9 KiB +6 B (+0.1%) 7.8 KiB
Codex Live turn WebSocket decoded 49.7 KiB 49.7 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 11.3 KiB 11.3 KiB +4 B (+0.0%) 15.1 KiB
Claude Thread snapshot wire 5.5 KiB 5.5 KiB 0 B (0.0%) 7.3 KiB
Claude Live turn WebSocket wire 5.9 KiB 5.9 KiB +4 B (+0.1%) 7.8 KiB
Claude Live turn WebSocket decoded 50.6 KiB 50.6 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: 89c320d · PR result: 6e87003 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

1 blocking correctness issue found.

You can customize Macroscope's approvability policy. Learn more.

@t3dotgg
t3dotgg merged commit 5208bde into main Aug 9, 2026
17 checks passed
@t3dotgg
t3dotgg deleted the t3code/fix-pinned-reorder-flicker branch August 9, 2026 01:46
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 9, 2026
## What's Changed
* chore: vouch gfsaaser24 by @t3dotgg in pingdotgg/t3code#5761
* chore: vouch saphid by @t3dotgg in pingdotgg/t3code#5763
* fix(server): stop Codex threads with queued follow-ups by @t3dotgg in pingdotgg/t3code#5762
* fix(web): usage page loses the cost quality panel, gains a back button by @t3dotgg in pingdotgg/t3code#5756
* feat(server): agents can now open the images you paste into chat by @t3dotgg in pingdotgg/t3code#5757
* fix(web): pinned reorder no longer reshuffles while writes land by @t3dotgg in pingdotgg/t3code#5767
* feat(web): overhaul project settings into a real settings page by @t3dotgg in pingdotgg/t3code#5768
* fix(web): usage totals no longer jump while devices report in by @t3dotgg in pingdotgg/t3code#5772
* fix(server): settle no longer leaves monitors and dev servers running by @t3dotgg in pingdotgg/t3code#5774
* feat: pick worktree or current checkout per project by @t3dotgg in pingdotgg/t3code#5766
* fix(web): sidebar rows show the branch again, not a truncated plan step by @t3dotgg in pingdotgg/t3code#5776
* feat(server): vp run migrate-dev-db seeds worktree dev dbs with real data by @t3dotgg in pingdotgg/t3code#5773
* feat(web): keep unsent drafts one click away in the sidebar by @t3dotgg in pingdotgg/t3code#5777


**Full Changelog**: pingdotgg/t3code@v0.0.33-nightly.20260809.1039...v0.0.33-nightly.20260809.1040

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.33-nightly.20260809.1040
incognitojam added a commit to yngatech/t3code that referenced this pull request Aug 9, 2026
The desktop update tooltip flattens the release body into plain bullet
lines, so the structured nightly highlights (`## Nightly highlights`,
`### Added`, …) rendered their headings as list items and wasted 3 of
the tooltip's 8 item slots. This PR makes the generated changelog and
the tooltip work together, and leans harder into the LLM pipeline while
keeping attribution.

## Changes

- **Nightly highlights are a flat list** of plain items with compact PR
references that survive the tooltip's markup stripping (`#61` for fork
PRs, `t3code#123` for upstream, short SHAs for direct commits). Removals
are phrased as "Remove …" via prompt guidance instead of a section
label.
- **Attribution is structural:** summary items are now `{ text,
evidenceIds }` objects. The model only returns evidence IDs; URLs are
rendered deterministically and IDs are validated against the collected
evidence, so references can't be fabricated. The rolling fork-features
issue gets the same per-item references.
- **Extraction sees diffs:** each commit contributes a truncated patch
(4 KB cap, lockfiles excluded) so descriptions are grounded in what
actually changed rather than paraphrasing PR titles. Over the 160k-char
prompt budget, the largest diffs are dropped first — titles and PR
bodies never are.
- **`## What's Changed` stays** as the exhaustive record and now credits
contributors once per PR (`by @username`, fetched via `gh api` with
graceful fallback).
- **The tooltip parser stops at `## What's Changed`** when curated
highlights precede it, so raw commit lines no longer mix with highlight
lines. Bodies that open with the commit list (upstream-style, or a
nightly with no highlights) still show it.

## Pipeline example

Evidence in (abridged; one upstream commit from the delta below):

```jsonc
{
  "id": "pingdotgg#5756",
  "title": "fix(web): usage page loses the cost quality panel, gains a back button",
  "description": "<sanitized PR body>",
  "files": ["apps/web/src/components/usage/UsagePage.tsx", "…"],
  "diff": "--- a/apps/web/src/components/usage/UsagePage.tsx\n+import { useCanGoBack, useNavigate, useRouter } from \"@tanstack/react-router\";\n…"
}
```

Summary items out (actual output — note one PR correctly yielding both
an improvement and a removal):

```json
{ "text": "Return from Usage through history or to home", "evidenceIds": ["pingdotgg#5756"] }
{ "text": "Remove Cost quality panel from the Usage page", "evidenceIds": ["pingdotgg#5756"] }
```

Rendered in the release body:

```markdown
- Return from Usage through history or to home ([t3code#5756](pingdotgg#5756))
- Remove Cost quality panel from the Usage page ([t3code#5756](pingdotgg#5756))
```

## Regenerated release notes for `v0.0.33-nightly.20260809.121`

Rerunning the new generator against the existing release's refs produced
13 items (the published release had 5, plus 3 heading lines). What the
tooltip shows, via the actual parser:

```
• Identify sidebar threads with unsent drafts (#23)
• Show subagent activity counts in right-panel controls (t3code#5745)
• Return from Usage through history or to home (t3code#5756)
• Give agents access to pasted image files (t3code#5757)
• Manage projects from the dedicated Settings page (t3code#5768)
• Preserve selected diff view across panel closures and reloads (t3code#5731)
• Show pointer cursors for clickable controls and actions (t3code#5716)
• Resume Claude sessions without falsely completing skipped turns (t3code#5710)
```

<details>
<summary>Full regenerated nightly highlights</summary>

- Identify sidebar threads with unsent drafts
([#23](#23))
- Show subagent activity counts in right-panel controls
([t3code#5745](pingdotgg#5745))
- Return from Usage through history or to home
([t3code#5756](pingdotgg#5756))
- Give agents access to pasted image files
([t3code#5757](pingdotgg#5757))
- Manage projects from the dedicated Settings page
([t3code#5768](pingdotgg#5768))
- Preserve selected diff view across panel closures and reloads
([t3code#5731](pingdotgg#5731))
- Show pointer cursors for clickable controls and actions
([t3code#5716](pingdotgg#5716))
- Resume Claude sessions without falsely completing skipped turns
([t3code#5710](pingdotgg#5710))
- Stop the active Codex turn before queued follow-ups
([t3code#5762](pingdotgg#5762))
- Keep pinned thread ordering stable while saving changes
([t3code#5767](pingdotgg#5767))
- Show multi-device usage progress while totals load
([t3code#5772](pingdotgg#5772))
- Remove Cost quality panel from the Usage page
([t3code#5756](pingdotgg#5756))
- Remove the limited project settings modal
([t3code#5768](pingdotgg#5768))

</details>

<details>
<summary>Regenerated rolling fork-features summary (excerpt, for issue
#43)</summary>

## Added

- Identify yngatech builds through names, icons, palettes, and About
details ([#3](#3),
[#27](#27),
[#29](#29),
[#30](#30),
[#56](#56))
- Choose and preview sounds for completed agent turns
([#5](#5),
[#7](#7),
[#19](#19))
- Detect GitHub outages and show status in the sidebar
([#14](#14))
- Show unsent thread drafts with sidebar pencil indicators
([#23](#23))
- Start new threads with GitHub issues as context
([#31](#31))
- Open thread pull or merge requests from command palette
([#46](#46))
- Synchronize existing-thread text and composer settings across
connected devices ([#39](#39),
[#44](#44))

## Improved

- Inspect full commands, labeled streams, numeric exit codes, and
failures ([#11](#11),
[#4](#4),
[#36](#36))
- Close terminals directly from the grouped terminal list
([#22](#22))
- Show clearer snooze countdowns near hour and day boundaries
([#45](#45))
- Show setup script outcomes in the thread timeline
([#40](#40))
- Install yngatech alongside upstream T3 Code on Windows
([#49](#49))

</details>

## Rollout

The generator and workflow changes take effect on the next nightly. The
tooltip parser change ships inside the app, so currently installed
builds still show the mixed list until users update onto a build
containing it.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant