Skip to content

feat(server): report setup script outcomes - #40

Merged
incognitojam merged 3 commits into
mainfrom
t3code/report-setup-script-errors
Aug 8, 2026
Merged

feat(server): report setup script outcomes#40
incognitojam merged 3 commits into
mainfrom
t3code/report-setup-script-errors

Conversation

@incognitojam

@incognitojam incognitojam commented Aug 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Setup scripts previously only reported that they started, leaving completion and failures invisible in the work log.

This runs setup scripts as tracked PTY commands and records requested, started, completed, and failed activities. The timeline folds lifecycle events with the same runId into one evolving row, even when unrelated activity lands between them. Interrupted runs retain a failure reason, interactive shell startup behavior stays compatible, and setup lifecycle activities remain UI-only rather than entering provider context.

Before

The existing behavior reported only that setup started, with no later completion or failure state:

Existing setup script started state

After

The same setup run now advances to its final failure state without leaving intermediate rows behind:

Failed setup script outcome

Verification

  • vp test run apps/server/src/project/ProjectSetupScriptRunner.test.ts apps/server/src/persistence/Layers/ProjectionThreadActivities.test.ts apps/server/src/terminal/Manager.test.ts (59 passed)
  • Focused provider-context and server-bootstrap tests passed
  • vp test run apps/web/src/session-logic.test.ts apps/web/src/components/chat/MessagesTimeline.test.tsx (89 passed)
  • vp run --filter t3 typecheck passed (existing Effect suggestions only)
  • vp run --filter web typecheck passed
  • Previewed the work-log flow in an isolated local T3 environment with success and failure fixtures

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@github-actions github-actions Bot added size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Aug 8, 2026
@incognitojam
incognitojam force-pushed the t3code/report-setup-script-errors branch from 4cc4888 to e9c5ee1 Compare August 8, 2026 12:21
@incognitojam
incognitojam force-pushed the t3code/report-setup-script-errors branch from aa0a9b3 to 03f8dfe Compare August 8, 2026 14:57
@incognitojam
incognitojam merged commit 49abf85 into main Aug 8, 2026
16 checks passed
@incognitojam
incognitojam deleted the t3code/report-setup-script-errors branch August 8, 2026 15:14
incognitojam added a commit that referenced this pull request Aug 9, 2026
@incognitojam @github-actions
feat(server): report setup script outcomes (#40)
f61def3 
* feat(server): report setup script outcomes

* fix(web): collapse setup lifecycle rows

* fix: close setup lifecycle recovery gaps

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@incognitojam incognitojam mentioned this pull request Aug 9, 2026
Merged
incognitojam added a commit that referenced this pull request Aug 9, 2026
@incognitojam @github-actions
fix(release): make nightly changelog tooltip-safe and attributed (#61)
6d3b823 
The desktop update tooltip flattens the release body into plain bullet
lines, so the structured nightly highlights (`## Nightly highlights`,
`### Added`, …) rendered their headings as list items and wasted 3 of
the tooltip's 8 item slots. This PR makes the generated changelog and
the tooltip work together, and leans harder into the LLM pipeline while
keeping attribution.

## Changes

- **Nightly highlights are a flat list** of plain items with compact PR
references that survive the tooltip's markup stripping (`#61` for fork
PRs, `t3code#123` for upstream, short SHAs for direct commits). Removals
are phrased as "Remove …" via prompt guidance instead of a section
label.
- **Attribution is structural:** summary items are now `{ text,
evidenceIds }` objects. The model only returns evidence IDs; URLs are
rendered deterministically and IDs are validated against the collected
evidence, so references can't be fabricated. The rolling fork-features
issue gets the same per-item references.
- **Extraction sees diffs:** each commit contributes a truncated patch
(4 KB cap, lockfiles excluded) so descriptions are grounded in what
actually changed rather than paraphrasing PR titles. Over the 160k-char
prompt budget, the largest diffs are dropped first — titles and PR
bodies never are.
- **`## What's Changed` stays** as the exhaustive record and now credits
contributors once per PR (`by @username`, fetched via `gh api` with
graceful fallback).
- **The tooltip parser stops at `## What's Changed`** when curated
highlights precede it, so raw commit lines no longer mix with highlight
lines. Bodies that open with the commit list (upstream-style, or a
nightly with no highlights) still show it.

## Pipeline example

Evidence in (abridged; one upstream commit from the delta below):

```jsonc
{
  "id": "pingdotgg#5756",
  "title": "fix(web): usage page loses the cost quality panel, gains a back button",
  "description": "<sanitized PR body>",
  "files": ["apps/web/src/components/usage/UsagePage.tsx", "…"],
  "diff": "--- a/apps/web/src/components/usage/UsagePage.tsx\n+import { useCanGoBack, useNavigate, useRouter } from \"@tanstack/react-router\";\n…"
}
```

Summary items out (actual output — note one PR correctly yielding both
an improvement and a removal):

```json
{ "text": "Return from Usage through history or to home", "evidenceIds": ["pingdotgg#5756"] }
{ "text": "Remove Cost quality panel from the Usage page", "evidenceIds": ["pingdotgg#5756"] }
```

Rendered in the release body:

```markdown
- Return from Usage through history or to home ([t3code#5756](pingdotgg#5756))
- Remove Cost quality panel from the Usage page ([t3code#5756](pingdotgg#5756))
```

## Regenerated release notes for `v0.0.33-nightly.20260809.121`

Rerunning the new generator against the existing release's refs produced
13 items (the published release had 5, plus 3 heading lines). What the
tooltip shows, via the actual parser:

```
• Identify sidebar threads with unsent drafts (#23)
• Show subagent activity counts in right-panel controls (t3code#5745)
• Return from Usage through history or to home (t3code#5756)
• Give agents access to pasted image files (t3code#5757)
• Manage projects from the dedicated Settings page (t3code#5768)
• Preserve selected diff view across panel closures and reloads (t3code#5731)
• Show pointer cursors for clickable controls and actions (t3code#5716)
• Resume Claude sessions without falsely completing skipped turns (t3code#5710)
```

<details>
<summary>Full regenerated nightly highlights</summary>

- Identify sidebar threads with unsent drafts
([#23](#23))
- Show subagent activity counts in right-panel controls
([t3code#5745](pingdotgg#5745))
- Return from Usage through history or to home
([t3code#5756](pingdotgg#5756))
- Give agents access to pasted image files
([t3code#5757](pingdotgg#5757))
- Manage projects from the dedicated Settings page
([t3code#5768](pingdotgg#5768))
- Preserve selected diff view across panel closures and reloads
([t3code#5731](pingdotgg#5731))
- Show pointer cursors for clickable controls and actions
([t3code#5716](pingdotgg#5716))
- Resume Claude sessions without falsely completing skipped turns
([t3code#5710](pingdotgg#5710))
- Stop the active Codex turn before queued follow-ups
([t3code#5762](pingdotgg#5762))
- Keep pinned thread ordering stable while saving changes
([t3code#5767](pingdotgg#5767))
- Show multi-device usage progress while totals load
([t3code#5772](pingdotgg#5772))
- Remove Cost quality panel from the Usage page
([t3code#5756](pingdotgg#5756))
- Remove the limited project settings modal
([t3code#5768](pingdotgg#5768))

</details>

<details>
<summary>Regenerated rolling fork-features summary (excerpt, for issue
#43)</summary>

## Added

- Identify yngatech builds through names, icons, palettes, and About
details ([#3](#3),
[#27](#27),
[#29](#29),
[#30](#30),
[#56](#56))
- Choose and preview sounds for completed agent turns
([#5](#5),
[#7](#7),
[#19](#19))
- Detect GitHub outages and show status in the sidebar
([#14](#14))
- Show unsent thread drafts with sidebar pencil indicators
([#23](#23))
- Start new threads with GitHub issues as context
([#31](#31))
- Open thread pull or merge requests from command palette
([#46](#46))
- Synchronize existing-thread text and composer settings across
connected devices ([#39](#39),
[#44](#44))

## Improved

- Inspect full commands, labeled streams, numeric exit codes, and
failures ([#11](#11),
[#4](#4),
[#36](#36))
- Close terminals directly from the grouped terminal list
([#22](#22))
- Show clearer snooze countdowns near hour and day boundaries
([#45](#45))
- Show setup script outcomes in the thread timeline
([#40](#40))
- Install yngatech alongside upstream T3 Code on Windows
([#49](#49))

</details>

## Rollout

The generator and workflow changes take effect on the next nightly. The
tooltip parser change ships inside the app, so currently installed
builds still show the mixed list until users update onto a build
containing it.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Aug 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@incognitojam