fix(mobile): keep ordered lists inside user bubbles - #6154
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 3b35142 This is a targeted Android mobile UI bug fix that adds ordered list detection for proper message bubble sizing. The changes are self-contained, well-tested, and limited to layout rendering logic with no security or data implications. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 3b35142
## What's Changed * feat(mobile): add thread title regeneration by @chrisdeeming in pingdotgg/t3code#6253 * chore: add dara to vouched by @maria-rcks in pingdotgg/t3code#6259 * fix(web): align the composer model picker by @t3-code[bot] in pingdotgg/t3code#6252 * fix(mobile): keep ordered lists inside user bubbles by @none23 in pingdotgg/t3code#6154 * feat(web): a better right panel empty state by @StiensWout in pingdotgg/t3code#6258 * fix(web): align mobile onboarding header by @t3-code[bot] in pingdotgg/t3code#6293 * fix(connect): preserve CLI OAuth parameters through browser sign-in by @juliusmarminge in pingdotgg/t3code#6285 ## New Contributors * @none23 made their first contribution in pingdotgg/t3code#6154 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260812.1072...v0.0.34-nightly.20260812.1076 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1076
What Changed
Extended fixed-width Markdown detection to recognize ordered-list markers in user messages.
Ordered lists now use the same definite-width Android bubble layout already used for fenced code blocks and GFM tables.
Why
Android can incorrectly measure list-item flex rows inside shrink-to-content user bubbles, causing ordered-list content to render outside the bubble and overlap subsequent messages.
A small regular-expression heuristic keeps the fix focused and avoids changing the shared list renderer. It trades some precision for simplicity, favoring harmless wider bubbles over false negatives that leave messages unreadable.
Fixes #6109.
UI Changes
Checklist
Note
Low Risk
Small mobile UI heuristic change scoped to Android chat bubble width. No auth, data, or shared renderer changes.
Overview
Fixes an Android layout bug where ordered lists in user chat bubbles could overflow and overlap nearby content.
Extends
hasWideMarkdownBlockto detect ordered-list markers (including nested and blockquoted lists), then pins those bubbles to a definite width—the same path already used for fenced code and tables. Ordered-list detection is enabled only on Android viaincludeOrderedLists, so iOS bubble sizing stays unchanged.Reviewed by Cursor Bugbot for commit 3b35142. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Keep ordered lists inside user message bubbles on Android
hasWideMarkdownBlockin wideMarkdownBlocks.ts to detect ordered lists (including nested and blockquoted items) and returntrueby default via a newincludeOrderedListsoption.WIDE_MARKDOWN_BLOCK_OPTIONSin ThreadFeed.tsx.stripBlockquotePrefixeshelper andhasOrderedListItemfunction handle edge cases like blockquoted lists and indented code blocks.Macroscope summarized 3b35142.