Skip to content

fix(web): align the composer model picker - #6252

Merged
maria-rcks merged 4 commits into
mainfrom
fix/composer-model-picker-hit-area
Aug 12, 2026
Merged

fix(web): align the composer model picker#6252
maria-rcks merged 4 commits into
mainfrom
fix/composer-model-picker-hit-area

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

summary

#5935 restored the model picker's shared start padding, but that pushed the provider icon inward from the prompt alignment.

this keeps the balanced control padding and offsets the whole trigger by the same 10px, so its pressed/hover background expands left while the icon returns to the composer content edge.

before / after

before after
before: model picker content inset too far after: model picker icon aligned while the background expands left

captured in an isolated T3 Code dev client at 1728x1000. the provider trigger was seeded into the real composer because the sandbox had no provider credentials.

verification

  • vp lint src/components/chat/ChatComposer.tsx --report-unused-disable-directives
  • vp fmt --check src/components/chat/ChatComposer.tsx
  • tsgo --noEmit for @t3tools/web
  • isolated web client visual pass

built with gpt-5.6-sol via hermes agent.

request provenance


Note

Low Risk
Pure CSS spacing tweak in the chat composer UI with no logic, auth, or data-handling changes.

Overview
Realigns the composer model picker so the provider icon sits on the prompt content edge again, without losing the shared start padding that keeps the control’s hover/press hit area balanced.

Adds -ms-3.5 / ps-3.5 on the footer scroller and shifts ProviderModelPicker’s triggerClassName from -ms-px to -ms-2.5, so the background expands left while the icon returns to alignment.

Reviewed by Cursor Bugbot for commit dd6ec18. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix alignment of the composer model picker in ChatComposer

Adjusts start-side spacing in ChatComposer.tsx to align the model picker trigger. Adds -ms-3.5 and ps-3.5 to the footer controls container and changes the ProviderModelPicker triggerClassName from -ms-px to -ms-2.5.

Macroscope summarized dd6ec18.

Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Aug 12, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 86002fb. Configure here.

Comment thread apps/web/src/components/chat/ChatComposer.tsx
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 11.3 KiB 11.3 KiB +30 B (+0.3%) 15.1 KiB
Codex Thread snapshot wire 5.5 KiB 5.5 KiB +6 B (+0.1%) 7.3 KiB
Codex Live turn WebSocket wire 5.9 KiB 5.9 KiB +24 B (+0.4%) 7.8 KiB
Codex Live turn WebSocket decoded 49.7 KiB 49.7 KiB 0 B (0.0%) 66.4 KiB
Codex Live turn messages 16 16 0 (0.0%) 21
Claude Total thread wire 11.3 KiB 11.3 KiB −10 B (−0.1%) 15.1 KiB
Claude Thread snapshot wire 5.5 KiB 5.5 KiB −4 B (−0.1%) 7.3 KiB
Claude Live turn WebSocket wire 5.9 KiB 5.9 KiB −6 B (−0.1%) 7.8 KiB
Claude Live turn WebSocket decoded 50.6 KiB 50.6 KiB 0 B (0.0%) 66.4 KiB
Claude Live turn messages 16 16 0 (0.0%) 21

Baseline: 560d4a4 · PR result: dd6ec18 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 94.6 KiB
  • Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved dd6ec18

Pure CSS alignment adjustment using Tailwind spacing utilities. Changes only affect visual positioning of the composer model picker with no impact on runtime logic or behavior.

You can customize Macroscope's approvability policy. Learn more.

Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 12, 2026
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 12, 2026 02:17

Dismissing prior approval to re-evaluate 2946ec0

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 12, 2026
Co-authored-by: maria <254055478+maria-rcks@users.noreply.github.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 12, 2026 02:26

Dismissing prior approval to re-evaluate dd6ec18

@maria-rcks
maria-rcks merged commit 5a84614 into main Aug 12, 2026
17 checks passed
@maria-rcks
maria-rcks deleted the fix/composer-model-picker-hit-area branch August 12, 2026 02:38
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 12, 2026
## What's Changed
* feat(mobile): add thread title regeneration by @chrisdeeming in pingdotgg/t3code#6253
* chore: add dara to vouched by @maria-rcks in pingdotgg/t3code#6259
* fix(web): align the composer model picker by @t3-code[bot] in pingdotgg/t3code#6252
* fix(mobile): keep ordered lists inside user bubbles by @none23 in pingdotgg/t3code#6154
* feat(web): a better right panel empty state by @StiensWout in pingdotgg/t3code#6258
* fix(web): align mobile onboarding header by @t3-code[bot] in pingdotgg/t3code#6293
* fix(connect): preserve CLI OAuth parameters through browser sign-in by @juliusmarminge in pingdotgg/t3code#6285

## New Contributors
* @none23 made their first contribution in pingdotgg/t3code#6154

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260812.1072...v0.0.34-nightly.20260812.1076

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant