fix(preview): make in-app browser automation work on real app pages - #7127
fix(preview): make in-app browser automation work on real app pages#7127gbarros-dev wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Reviewed the Effect service conventions for the changed preview automation code. Two error-modeling violations: a new failureKind discriminator selects the user-facing message in both the desktop and web target-not-found errors, and the new host error drops the underlying failure instead of preserving it as cause. Imports, service definition/layer shape, dependency acquisition, and runtime boundaries in the touched code all look fine.
Posted via Macroscope — Effect Service Conventions
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0f2d5d3. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces significant new capabilities (viewport control, scoped element search) and changes runtime behavior (element detection, main-landmark preference for visible text) beyond what the 'fix' label suggests. The scope of changes across preview automation warrants human review. You can customize Macroscope's approvability policy. Learn more. |
|
Closing to split this into smaller PRs. The problem is still real. The change was four independent fixes sharing one review and then conflicting with #7082. Replacement PRs, in this order:
This branch is not being merged. |
|
Replacement PRs:
|

Agents inspecting a real app in the in-app browser were drowning in accessibility trees, matching sidebar chrome on wait, treating hidden buttons as missing, and timing out on resize when the preview panel was not visible.
Snapshots are slim by default (screenshot, main-landmark text, visible clickable elements). Wait defaults to
main. Click reports hidden, disabled, or ambiguous targets without leaking locators. Local environment ports resolve tolocalhostso Vite on::1or127.0.0.1is reachable. Resize applies through CDP even when the panel is hidden. Console and network stay behindpreview_snapshotinclude.The preview tools assumed a simple, visible page. Real product UIs have sidebars, hidden dialog triggers, and dual-stack local servers, so agents spent turns fighting the harness instead of the app.
Implemented with Grok 4.6 through Grok CLI.
Note
Medium Risk
Touches desktop CDP automation, IPC contracts, and navigation URL resolution; behavior changes for agents using snapshot, wait, click, and resize, but scoped to preview automation with rollback and backward-compatible optional APIs.
Overview
Preview automation is tuned for real product UIs: slimmer defaults, clearer click failures, and guest viewport control when the panel is hidden.
Snapshots default to URL, main-landmark visible text, filtered interactive elements (with stable
e1ids), screenshot, and action timeline. Heavier accessibility, console, and network data load only whenincluderequests them; AX tree fetch and optional slices are skipped otherwise, with screenshot fallback ifcapturePagefails.Click resolution distinguishes missing, hidden, disabled, and ambiguous (strict-mode) targets via new typed errors, mapped on the web host to execution messages without leaking locators. Wait-for gains optional
scope(mainvsdocument), searches text/locators in that root, requires visibility, and ignores dialog trigger slots.Resize persists server viewport state and applies CDP device metrics on the guest (
setViewport/ clear for fill), including rollback on failure and manual chrome resize—so automation size changes work when the preview is not visible.Local dev URLs map loopback environment hosts (
127.0.0.1,::1) tolocalhostso dual-stack guests reach Vite bound on either stack.Contracts, IPC/preload, MCP tool descriptions, and tests cover the new inputs and error shapes.
Reviewed by Cursor Bugbot for commit f7d8c91. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix in-app browser automation to work on real app pages by adding viewport override and richer snapshot support
setViewportIPC channel and bridge method that applies or clears a CDPEmulation.setDeviceMetricsOverrideper tab, so viewport changes take effect immediately in the guest webview.automationSnapshotto accept optionalincludeflags (ax,console,network), making snapshots slimmer by default and returning diagnostics only on demand.hidden,disabled,ambiguous) instead of a generic not-found error, and maps these through the host-side error layer.::1,127.0.0.1) tolocalhostinresolveEnvironmentPortTargetfor dual-stack server compatibility.PreviewAutomationWaitForgains an optionalscopefield (main|document) to constrain text/selector matching to the main landmark.Macroscope summarized f7d8c91.