fix(preview): name hidden, disabled, and ambiguous click failures

[gbarros-dev]

preview_click treated a hidden or disabled button as missing and leaked the locator when it failed. Agents then spent turns guessing at chrome they could already see.

Clicks now report hidden, disabled, or ambiguous targets without putting the locator on the wire.

Related to #3714. Does not close it: that issue wants the selector in the error; this PR names the failure kind and keeps locators off the wire.

Split out of closed #7127.

Tests: vp test run apps/desktop/src/preview/Manager.test.ts apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts

Implemented with Grok 4.6 through Grok CLI.

---

Note

Low Risk
Scoped to preview automation error typing and click target resolution messaging; no auth, data, or payment paths. Type/scroll paths are unchanged.

Overview
Preview selector-based clicks no longer collapse hidden, disabled, or multi-match failures into a single “not found.” The in-page lookup returns a structured failureKind, and desktop PreviewManager raises hidden, disabled, ambiguous (with match count), or missing errors via PreviewAutomationTargetNotFoundError.fromLookupFailure. Ambiguous matches are detected when Playwright strict mode throws.

The web preview automation layer maps those desktop tags to matching *HostError types so agents get clear execution messages (e.g. not visible, disabled, matched N elements) while serialized responses stay free of locator text, covered by new desktop and web tests.

^{Reviewed by Cursor Bugbot for commit a149228. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add named error types for hidden, disabled, and ambiguous click failures in preview automation

• Distinguishes click-target failures into four specific error kinds — hidden, disabled, ambiguous (with match count), and missing — instead of a single generic not-found error, both on the desktop side (Manager.ts) and the web host side (previewAutomationErrors.ts).
• The injected evaluateWithDebugger snippet now catches strict-mode errors to surface ambiguous selectors with a matchCount, and explicitly checks visibility and enabled state.
• PreviewAutomationTargetNotFoundError.fromLookupFailure maps a failureKind to the appropriate concrete error class; the host-side PreviewAutomationOperationError.fromCause does the same for client-visible messages.
• All error messages are redacted so locator strings are not exposed to clients.

^{Macroscope summarized a149228.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved a149228

This PR improves error categorization for preview automation click failures, distinguishing between hidden, disabled, and ambiguous targets. The changes are self-contained error handling improvements with comprehensive test coverage and no runtime behavior changes beyond better error messages.

^{You can customize Macroscope's approvability policy. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}