fix(web): fold single trailing activity - #9739
Merged
maria-rcks merged 3 commits intoSep 4, 2026
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped web timeline fix that folds only a single ordinary trailing activity while preserving visibility for failures and larger groups. The production change is isolated and covered by focused tests, with no schema, deployment, security, billing, or configuration impact. Notes:
You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
September 4, 2026 18:05
Dismissing prior approval to re-evaluate 59ade45
macroscopeapp
Bot
dismissed
their stale review
September 4, 2026 18:11
Dismissing prior approval to re-evaluate 4c785d5
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 4, 2026
## What's Changed * perf(server): use one query for buffered provider events by @t3dotgg in pingdotgg/t3code#9706 * perf(relay): avoid repeated activity decoding by @t3dotgg in pingdotgg/t3code#9708 * perf(web): stop continuous chat status animations by @t3dotgg in pingdotgg/t3code#9709 * fix(mobile): preserve saved work after storage read failures by @t3dotgg in pingdotgg/t3code#9710 * perf(web): stop replaying terminal buffers on rollover by @t3dotgg in pingdotgg/t3code#9707 * feat(web): preview pull request links by @maria-rcks in pingdotgg/t3code#9631 * perf(client): reduce thread-list update work by @t3dotgg in pingdotgg/t3code#9716 * fix(server): settle inactive threads with open PRs by @Gigioxx in pingdotgg/t3code#9610 * fix(server): bound slow-client event buffers by @t3dotgg in pingdotgg/t3code#9715 * test(server): allow either valid file-search match by @t3dotgg in pingdotgg/t3code#9720 * fix(web): match provider settings layout for disconnected devices by @flamboh in pingdotgg/t3code#9619 * fix(web): keep the slash menu above the composer when vertical space is short by @Mnigos in pingdotgg/t3code#9625 * fix(mobile): remove provider setup by @juliusmarminge in pingdotgg/t3code#9721 * perf(web): stop rendering hidden terminals by @t3dotgg in pingdotgg/t3code#9718 * fix(mobile): read file-backed image drafts before enabling them by @t3dotgg in pingdotgg/t3code#9713 * perf(server): replay only the selected thread by @t3dotgg in pingdotgg/t3code#9726 * fix(web): mute composer helper text by @jakeleventhal in pingdotgg/t3code#9654 * feat(web): unpin threads from the sidebar multi-select menu by @gsimone in pingdotgg/t3code#9651 * perf(web): reuse timeline rows while text streams by @t3dotgg in pingdotgg/t3code#9725 * fix(relay): bound stalled push requests by @t3dotgg in pingdotgg/t3code#9734 * perf(server): stop caching unused OpenCode tool parts by @t3dotgg in pingdotgg/t3code#9738 * fix(web): fold single trailing activity by @maria-rcks in pingdotgg/t3code#9739 * fix(web): show project settings for new threads by @maria-rcks in pingdotgg/t3code#9743 * perf(mobile): bound the parsed review cache by @t3dotgg in pingdotgg/t3code#9749 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260904.1279...v0.0.39-nightly.20260904.1280 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260904.1280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single trailing activity rows could appear below the "Worked for ..." fold. This folds one ordinary trailing activity while leaving larger groups, failures, agent spawns, and compaction visible. Verified with 84 focused tests, web typecheck, targeted lint, and the real expand/collapse interaction.
Created with
gpt-5.6-solin T3 Code.Note
Low Risk
UI-only timeline folding logic with targeted unit and render tests; no API or data-path changes.
Overview
Settled turns no longer leave a lone successful tool row dangling below the final assistant message and the Worked for… fold.
deriveTurnFoldsnow treats one non-failing work entry immediately after the terminal assistant message as part of the fold (same hidden set as pre-terminal activity). Multiple trailing entries, failed tools, compaction, and agent-spawn rows still stay visible as trailing summaries.Tests cover the folded single-trailing case and align the trailing-tool integration fixture with failed lifecycle so failures remain outside the fold.
Reviewed by Cursor Bugbot for commit 4c785d5. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix folding of single trailing activity in
chat.deriveMessagesTimelineRowsFixes the timeline row derivation so a single trailing activity folds correctly into the turn-fold row rather than producing extra rows. The test in MessagesTimeline.logic.test.ts now refactors the settled-error setup into a reusable typed input and asserts that a shortened timeline yields only the turn-fold row and terminal assistant row, with no trailing work toggle or assistant metadata row.
Macroscope summarized 4c785d5.