Skip to content

fix(web): show project settings for new threads - #9743

Merged
maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:fix/project-breadcrumb-draft-menu
Sep 4, 2026
Merged

fix(web): show project settings for new threads#9743
maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:fix/project-breadcrumb-draft-menu

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

new-thread drafts returned before preventing the breadcrumb context-menu event, so desktop showed its generic edit menu. this adds the existing project settings action for draft breadcrumbs and routes it through the draft's logical project key while preserving established-thread actions and left-click behavior.

verified with the focused chat-header test, web typecheck, targeted lint and formatting, and the live draft-to-project-settings flow.

before

before: generic desktop edit menu on the new-thread project breadcrumb

after

after: project settings menu on the new-thread project breadcrumb

interaction

right-click project settings menu opening the project's settings page

built with gpt-5.6-sol via the codex harness.


Note

Low Risk
Localized UI/navigation change for draft-thread header context menus with no auth or data-model impact.

Overview
Fixes the new-thread project breadcrumb so right-click opens Project settings instead of the generic desktop edit menu on draft threads.

ChatView now derives the draft’s logical project key (same grouping settings as established threads) and passes an optional onOpenProjectSettings handler that navigates to /projects/$projectKey. ChatHeader accepts that callback and, for non-server threads, calls preventDefault and shows a native Project settings item via readLocalApi().contextMenu before returning—so the event is no longer left to bubble into the default OS menu. Established server threads still use the existing thread action context menu; left-click rename behavior is unchanged.

Reviewed by Cursor Bugbot for commit f8fe702. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Project settings context-menu item for draft thread breadcrumbs

  • ChatView derives a logical project key for the active draft project and passes a navigation callback to WorkspacePageHeader when that key exists.
  • ChatHeader accepts an optional project-settings callback. Right-clicking the breadcrumb area of a draft chat shows a Project settings context menu item at the pointer that invokes the callback.
  • Server-thread right-clicks retain the existing thread menu behavior and do not receive the project-settings action.
  • Risk: title-area right-click handling in ChatHeader.tsx is no longer limited to server threads; verify draft threads without a project key do not render an empty menu item.

Macroscope summarized f8fe702.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 4, 2026
Comment thread apps/web/src/components/ChatView.tsx Outdated
@macroscopeapp

macroscopeapp Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at f8fe702

Macroscope's review found this PR approvable — This is a localized web UI fix that exposes the existing Project settings action for new-thread breadcrumbs while preserving established-thread menus and click behavior. It introduces no schema, infrastructure, security, billing, or configuration-default changes.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcks merged commit cbe93e8 into pingdotgg:main Sep 4, 2026
25 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 4, 2026
## What's Changed
* perf(server): use one query for buffered provider events by @t3dotgg in pingdotgg/t3code#9706
* perf(relay): avoid repeated activity decoding by @t3dotgg in pingdotgg/t3code#9708
* perf(web): stop continuous chat status animations by @t3dotgg in pingdotgg/t3code#9709
* fix(mobile): preserve saved work after storage read failures by @t3dotgg in pingdotgg/t3code#9710
* perf(web): stop replaying terminal buffers on rollover by @t3dotgg in pingdotgg/t3code#9707
* feat(web): preview pull request links by @maria-rcks in pingdotgg/t3code#9631
* perf(client): reduce thread-list update work by @t3dotgg in pingdotgg/t3code#9716
* fix(server): settle inactive threads with open PRs by @Gigioxx in pingdotgg/t3code#9610
* fix(server): bound slow-client event buffers by @t3dotgg in pingdotgg/t3code#9715
* test(server): allow either valid file-search match by @t3dotgg in pingdotgg/t3code#9720
* fix(web): match provider settings layout for disconnected devices by @flamboh in pingdotgg/t3code#9619
* fix(web): keep the slash menu above the composer when vertical space is short by @Mnigos in pingdotgg/t3code#9625
* fix(mobile): remove provider setup by @juliusmarminge in pingdotgg/t3code#9721
* perf(web): stop rendering hidden terminals by @t3dotgg in pingdotgg/t3code#9718
* fix(mobile): read file-backed image drafts before enabling them by @t3dotgg in pingdotgg/t3code#9713
* perf(server): replay only the selected thread by @t3dotgg in pingdotgg/t3code#9726
* fix(web): mute composer helper text by @jakeleventhal in pingdotgg/t3code#9654
* feat(web): unpin threads from the sidebar multi-select menu by @gsimone in pingdotgg/t3code#9651
* perf(web): reuse timeline rows while text streams by @t3dotgg in pingdotgg/t3code#9725
* fix(relay): bound stalled push requests by @t3dotgg in pingdotgg/t3code#9734
* perf(server): stop caching unused OpenCode tool parts by @t3dotgg in pingdotgg/t3code#9738
* fix(web): fold single trailing activity by @maria-rcks in pingdotgg/t3code#9739
* fix(web): show project settings for new threads by @maria-rcks in pingdotgg/t3code#9743
* perf(mobile): bound the parsed review cache by @t3dotgg in pingdotgg/t3code#9749


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260904.1279...v0.0.39-nightly.20260904.1280

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260904.1280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant