Skip to content

Add maintainer/approver groups as dependency file owners - #8933

Merged
kachawla merged 4 commits into
radius-project:mainfrom
kachawla:codeowners-update
Mar 24, 2025
Merged

kachawla merged 4 commits into
radius-project:mainfrom
kachawla:codeowners-update

Conversation

@kachawla

@kachawla kachawla commented Mar 21, 2025 •

Copy link
Copy Markdown
Member

Description

Two updates

  • Add maintainer/approver groups as dependency file owners: The most specific rule takes precedence over more general ones. This means that if a file or directory matches multiple rules, the one with the narrower scope (e.g., a specific file or subdirectory) will override more general ones (e.g., the root * rule). So we need to add maintainer/approver teams explicitly to the files that oncall team is added as owner for.

  • Add oncall team as owner for dockerfile for snyk updates

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
@kachawla
kachawla requested review from a team as code owners March 21, 2025 18:55
@radius-functional-tests

radius-functional-tests Bot commented Mar 21, 2025 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 5e156db
Unique ID func854b112e1b
Image tag pr-func854b112e1b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func854b112e1b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func854b112e1b
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func854b112e1b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func854b112e1b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func854b112e1b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

@codecov

codecov Bot commented Mar 21, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.64%. Comparing base (a3d318d) to head (25e1f6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8933      +/-   ##
==========================================
- Coverage   55.65%   55.64%   -0.02%     
==========================================
  Files         599      599              
  Lines       40750    40750              
==========================================
- Hits        22681    22675       -6     
- Misses      16351    16355       +4     
- Partials     1718     1720       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@radius-functional-tests

radius-functional-tests Bot commented Mar 23, 2025 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 0b62284
Unique ID func21232f335d
Image tag pr-func21232f335d
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func21232f335d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func21232f335d
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func21232f335d
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func21232f335d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func21232f335d
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests

radius-functional-tests Bot commented Mar 24, 2025 •

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 25e1f6f
Unique ID func1d721793bd
Image tag pr-func1d721793bd
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1d721793bd
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1d721793bd
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1d721793bd
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1d721793bd
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1d721793bd
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla
kachawla merged commit 202e099 into radius-project:main Mar 24, 2025
@kachawla
kachawla deleted the codeowners-update branch March 24, 2025 23:09

This branch was previously deployed

2 inactive deployments
functional-tests — 25e1f6f6 Deployed Mar 24, 2025 by kachawla
publish-bicep — 25e1f6f6 Deployed Mar 24, 2025 by kachawla
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants