Repository navigation
Adding on-call team as owner for dependency-related files - #8884
Conversation
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
d4a90df to
f1765ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8884 +/- ##
==========================================
- Coverage 59.89% 59.89% -0.01%
==========================================
Files 595 595
Lines 40481 40481
==========================================
- Hits 24248 24245 -3
- Misses 14406 14408 +2
- Partials 1827 1828 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
brooke-hamilton
left a comment
There was a problem hiding this comment.
While in the on-call role I'm unable to approve this Snyk PR which edits a Dockerfile, so maybe we need to add Dockerfiles as well. What do you think?
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
@brooke-hamilton addressed in #8933 |
# Description I recently added on-call group as owner for a few dependency related files to allow on-call to handle depedenabot/snyk PRs: #8884. However, looking at the list again, I realized that github workflows have a lot of core functionality and are generally not limited to version updates, so removing on-call team from the codeowners list for github workflows. Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
Description
Adding on-call team as owner for dependency-related files to allow them to approve and merge version updates (Dependabot PRs).
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: