Update codeowners: Remove oncall team from github workflows by kachawla · Pull Request #8955 · radius-project/radius

kachawla · 2025-03-24T23:08:47Z

Description

I recently added on-call group as owner for a few dependency related files to allow on-call to handle depedenabot/snyk PRs: #8884. However, looking at the list again, I realized that github workflows have a lot of core functionality and are generally not limited to version updates, so removing on-call team from the codeowners list for github workflows.

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

Signed-off-by: Karishma Chawla <kachawla@microsoft.com>

radius-functional-tests · 2025-03-24T23:17:25Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	kachawla/radius
Commit ref	`d37a877`
Unique ID	funcf981116dfa
Image tag	pr-funcf981116dfa

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf981116dfa
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf981116dfa
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcf981116dfa
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf981116dfa
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf981116dfa
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

codecov · 2025-03-24T23:25:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.65%. Comparing base (207b9f7) to head (eba7cb1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8955   +/-   ##
=======================================
  Coverage   55.65%   55.65%           
=======================================
  Files         599      599           
  Lines       40750    40750           
=======================================
  Hits        22681    22681           
  Misses      16351    16351           
  Partials     1718     1718

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kachawla

radius-functional-tests · 2025-03-25T04:01:07Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	kachawla/radius
Commit ref	`a6a47ed`
Unique ID	func5144ded074
Image tag	pr-func5144ded074

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5144ded074
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5144ded074
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func5144ded074
controller test image location: ghcr.io/radius-project/dev/controller:pr-func5144ded074
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5144ded074
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

ytimocin

would removing both lines affect the permissions for approvers and/or maintainers?

kachawla · 2025-03-26T20:47:03Z

would removing both lines affect the permissions for approvers and/or maintainers?

no, the repository level ownership "* @radius-project/maintainers-radius @radius-project/approvers-radius" will still continue to let approvers/maintainers approve workflow files. Removing these lines will just remove oncall as the owner for these.

Thanks for reviewing!

radius-functional-tests · 2025-03-26T20:48:10Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	kachawla/radius
Commit ref	`eba7cb1`
Unique ID	funcf02063b2a8
Image tag	pr-funcf02063b2a8

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcf02063b2a8
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcf02063b2a8
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcf02063b2a8
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcf02063b2a8
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcf02063b2a8
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Update codeowners: Remove oncall team from github workflows

d37a877

Signed-off-by: Karishma Chawla <kachawla@microsoft.com>

kachawla requested review from a team as code owners March 24, 2025 23:08

kachawla temporarily deployed to publish-bicep March 24, 2025 23:09 — with GitHub Actions Inactive

kachawla temporarily deployed to functional-tests March 24, 2025 23:10 — with GitHub Actions Inactive

kachawla commented Mar 24, 2025

View reviewed changes

kachawla requested a review from ytimocin March 25, 2025 01:00

Merge branch 'main' into codeowners

a6a47ed

kachawla temporarily deployed to publish-bicep March 25, 2025 01:00 — with GitHub Actions Inactive

kachawla temporarily deployed to functional-tests March 25, 2025 04:00 — with GitHub Actions Inactive

Merge branch 'main' into codeowners

eba7cb1

kachawla temporarily deployed to publish-bicep March 26, 2025 20:43 — with GitHub Actions Inactive

ytimocin approved these changes Mar 26, 2025

View reviewed changes

kachawla temporarily deployed to functional-tests March 26, 2025 20:47 — with GitHub Actions Inactive

kachawla merged commit e442fb4 into radius-project:main Mar 26, 2025

Navigation Menu

Repository navigation

Update codeowners: Remove oncall team from github workflows - #8955

Update codeowners: Remove oncall team from github workflows#8955
kachawla merged 3 commits into
radius-project:mainfrom
kachawla:codeowners

kachawla commented Mar 24, 2025 •

edited

Loading

Uh oh!

radius-functional-tests Bot commented Mar 24, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Mar 24, 2025 •

edited

Loading

Uh oh!

kachawla left a comment •

edited

Loading

Uh oh!

radius-functional-tests Bot commented Mar 25, 2025 •

edited

Loading

Uh oh!

ytimocin left a comment

Uh oh!

kachawla commented Mar 26, 2025

Uh oh!

radius-functional-tests Bot commented Mar 26, 2025 •

edited

Loading

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kachawla commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Contributor checklist

Uh oh!

radius-functional-tests Bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

codecov Bot commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kachawla left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

radius-functional-tests Bot commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

ytimocin left a comment

Choose a reason for hiding this comment

Uh oh!

kachawla commented Mar 26, 2025

Uh oh!

radius-functional-tests Bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Radius functional test overview

Test Status

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kachawla commented Mar 24, 2025 •

edited

Loading

radius-functional-tests Bot commented Mar 24, 2025 •

edited

Loading

codecov Bot commented Mar 24, 2025 •

edited

Loading

kachawla left a comment •

edited

Loading

radius-functional-tests Bot commented Mar 25, 2025 •

edited

Loading

radius-functional-tests Bot commented Mar 26, 2025 •

edited

Loading