Remove infoLog invocations from react-native and rn-tester#51600
Closed
coado wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75402930 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75402930 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75402930 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75402930 |
Summary: Pull Request resolved: #51600 The `infoLog` is a `console.log` wrapper to separate ad-hoc console debug logging, however console logs are already used in some files in rn-tester (ex. RNTesterAppShared.js). The same applies to files in react-native package. Changelog: [General][Changed] - Removed `infoLog` from react-native package Reviewed By: huntie Differential Revision: D75402930
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75402930 |
Collaborator
|
This pull request was successfully merged by @coado in 8a0cfec When will my fix make it into a release? | How to file a pick request? |
CarSmallGuo
pushed a commit
to CarSmallGuo/ohos_react_native_new
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Patryk Fryda<patryk.fryda@swmansion.com> # message auto-generated for no-merge-commit merge: !1843 merge 0.82 into 0.82 chore: update react-native to 0.82.1 Created-by: pafry Commit-by: Patryk Fryda Merged-by: huangyouhua Description: # https://gitcode.com/openharmony-sig/ohos_react_native/merge_requests/1835 has to be merged first. ## Why are these changes being made? There is ongoing effort to update react-native and RNOH to 0.82. This is the last step. ### Notable react-native changes: - react/react-native#51600 - infoLog removal - react/react-native#53094 - changing libhermes to libhermesvm - react/react-native#52610 - moving ReactNativeFeatureFlags to src/private - react/react-native#53360 - stable DOM API - react/react-native#52750 - Install ContextContainer::Shared with std::shared_ptr ### Other changes: - replaced custom RNOH cxx turbomodules ## Changelog - updated react-native to 0.82.1 ## Test Plan - launch tester app, - run sequential and concurrent tests ## Checklist - [x] `pnpm verify` command has passed successfully. - [x] No failures occurred in automatic tests on the `CONCURRENT TESTER` page in the tester app. - [x] No failures occurred in automatic tests on the `SEQUENTIAL TESTER` page in the tester app. - [x] MR does not include a breaking change or a review has been requested from a Huawei reviewer. See merge request: openharmony-sig/ohos_react_native!1843
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
infoLogis aconsole.logwrapper to separate ad-hoc console debug logging, however console logs are already used in some files in rn-tester (ex. RNTesterAppShared.js). The same applies to files in react-native package.Changelog:
[General][Changed] - Removed
infoLogfrom react-native packageReviewed By: huntie
Differential Revision: D75402930