Change hermes atrifact names#53094
Closed
j-piasecki wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
facebook-github-bot
added
p: Software Mansion
j-piasecki
force-pushed
the
export-D79163127
branch
from
ab1b047 to
4ca7122
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
4ca7122 to
b06747d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
b06747d to
7a442a1
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
7a442a1 to
7c9ac0d
Compare
j-piasecki
force-pushed
the
export-D79163127
branch
from
7c9ac0d to
3b69b9c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
3b69b9c to
6162fb3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
6162fb3 to
ea627bb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
ea627bb to
9e822eb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
9e822eb to
5e6b5d6
Compare
Summary: Pull Request resolved: #53094 Changelog: [General][Changed] - Changed names of hermes binaries Reviewed By: cipolleschi, cortinico Differential Revision: D79163127
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79163127 |
j-piasecki
force-pushed
the
export-D79163127
branch
from
5e6b5d6 to
d9cdf8c
Compare
Contributor
|
This pull request has been merged in 776fca1. |
Collaborator
|
This pull request was successfully merged by @j-piasecki in 776fca1 When will my fix make it into a release? | How to file a pick request? |
github-merge-queue Bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Sep 2, 2025
## Summary In react/react-native#53094 `hermes-engine::libhermes` prefab was renamed to `hermes-engine::hermesvm` and nightly builds are broken now so we need to adapt to this change on our side. cc @cortinico ## Test plan --------- Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
MatiPl01
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Oct 28, 2025
## Summary In react/react-native#53094 `hermes-engine::libhermes` prefab was renamed to `hermes-engine::hermesvm` and nightly builds are broken now so we need to adapt to this change on our side. cc @cortinico ## Test plan --------- Co-authored-by: Jakub Piasecki <jakub.piasecki@swmansion.com>
CarSmallGuo
pushed a commit
to CarSmallGuo/ohos_react_native_new
that referenced
this pull request
Mar 25, 2026
Co-authored-by: Patryk Fryda<patryk.fryda@swmansion.com> # message auto-generated for no-merge-commit merge: !1843 merge 0.82 into 0.82 chore: update react-native to 0.82.1 Created-by: pafry Commit-by: Patryk Fryda Merged-by: huangyouhua Description: # https://gitcode.com/openharmony-sig/ohos_react_native/merge_requests/1835 has to be merged first. ## Why are these changes being made? There is ongoing effort to update react-native and RNOH to 0.82. This is the last step. ### Notable react-native changes: - react/react-native#51600 - infoLog removal - react/react-native#53094 - changing libhermes to libhermesvm - react/react-native#52610 - moving ReactNativeFeatureFlags to src/private - react/react-native#53360 - stable DOM API - react/react-native#52750 - Install ContextContainer::Shared with std::shared_ptr ### Other changes: - replaced custom RNOH cxx turbomodules ## Changelog - updated react-native to 0.82.1 ## Test Plan - launch tester app, - run sequential and concurrent tests ## Checklist - [x] `pnpm verify` command has passed successfully. - [x] No failures occurred in automatic tests on the `CONCURRENT TESTER` page in the tester app. - [x] No failures occurred in automatic tests on the `SEQUENTIAL TESTER` page in the tester app. - [x] MR does not include a breaking change or a review has been requested from a Huawei reviewer. See merge request: openharmony-sig/ohos_react_native!1843
Saadnajmi
added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jul 8, 2026
… 0.84 Upstream 0.83-stable defaults to Hermes V0 (sdks/.hermesversion = hermes-v0.14.1); V1 is opt-in via RCT_HERMES_V1_ENABLED and only becomes the default in 0.84 (react#54989, commit bbe02de, not backported to 0.83). The `hermes` -> `hermesvm` product rename, however, already landed in 0.83 (react#53094), so the fork's resolve-hermes.mts genuinely needed to catch up to the new artifact name. Reduce the PR to just that V0-compatible rename catch-up and revert the V1-engine bits to match upstream 0.83: - resolve-hermes.mts: keep hermes.* -> hermesvm.* (needed on 0.83). - Package.swift: drop HERMES_V1_ENABLED define (inherited at 0.84 merge). - microsoft-hermes.js: revert static_h -> main; drop unused hermesV1Tag(). - hermes-utils.rb: revert static_h/main gate back to main (V0). - build-apple-framework.sh: revert inspector-header guard (V0 ships them). - microsoft-resolve-hermes.yml: revert cache-key rename + cmake hermesc change (build_host_hermesc works for V0). Net: 6 files -> 1; the five reverted files now match upstream/0.83-merge. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General][Changed] - Changed names of hermes binaries
Rollback Plan:
Differential Revision: D79163127