Repository navigation
Conversation
… without breaking existing hooks
gilou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned on #544 , but also in other places, if we need to use the refresh_token logic on endpoints that expect JSON instead of x-www-form-urlencoded, well, we can't, because we are given only body in the hooks, which is passed as keyword argument data for Request().
This PR tries to address it by checking if the Content-Type header was set to application/json, and if so, submits the data using the json parameter.
My opinion would be to make the refresh_token_request hooks behave the same as access_token_request, and allow to manipulate kwargs for the request, but that would break existing hooks that are used to manipulate the body/data directly.