Skip to content

Allow refresh_token_request compliance hooks to actually use JSON #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilou wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow refresh_token_request compliance hooks to actually use JSON #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion requests_oauthlib/oauth2_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,15 +473,29 @@ def refresh_token(
log.debug("Invoking refresh_token_request hook %s.", hook)
token_url, headers, body = hook(token_url, headers, body)

# Hooks expected body to be a string until now, but if they do need
# to output JSON, we need to make Request() use json instead of data.
# This is a way to avoid breaking existing hooks. A better approach
# would be to do the same as what fetch_token does, and let the hooks
# be able to manipulate req_kwargs the way they want.
request_kwargs = {}
req_data = "data"

if headers["Content-Type"] == "application/json":
req_data = "json"

request_kwargs[req_data] = dict(urldecode(body))


r = self.post(
token_url,
data=dict(urldecode(body)),
auth=auth,
timeout=timeout,
headers=headers,
verify=verify,
withhold_token=True,
proxies=proxies,
**request_kwargs
)
log.debug("Request to refresh token completed with status %s.", r.status_code)
log.debug("Response headers were %s and content %s.", r.headers, r.text)
Expand Down