Repository navigation
fix: add support for QNX8 - #670
Conversation
a84efe4 to
b8acf7c
Compare
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Code changes LGTM, but we'll have to wait on rust-lang/libc#5469 before we can merge this.
Maybe we want to add a CI job for QNX to catch this in future?
|
The QNX toolchain requires licenses. I'm not sure what's Blackberry's stand on providing free licenses for open-source projects. But that would be good for sure! It is a Tier 3 target tho, so there's no project-wide mandate to keep this working |
|
We can do a |
|
@lambinoo if you can update the libc version to include rust-lang/libc#5469 we can merge this. |
|
Hey! Sorry for the delay. It still needs to be backported to the libc 0.2.x. I just opened a PR for that a few minutes ago
Otherwise, can always redirect qnx to the 1.0 branch but it's not really released. But that doesn't seem ideal
…-------- Original Message --------
On Friday, 09/11/26 at 14:26 Thomas de Zeeuw ***@***.***> wrote:
Thomasdezeeuw left a comment [(rust-lang/socket2#670)](#670 (comment))
***@***.***(https://github.com/lambinoo) if you can update the libc version to include [rust-lang/libc#5469](rust-lang/libc#5469) we can merge this.
—
Reply to this email directly, [view it on GitHub](#670?email_source=notifications&email_token=ANWHUJCPDDCD7OPGVW5VIND5OPVQ3A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNRTGQ2DCNJTGY2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5634415364), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ANWHUJAD7K5GEHR7GJKDQLL5OPVQ3AVCNFSNUABEKJSXA33TNF2G64TZHM4TAOBSGE4TGMB3JFZXG5LFHM2TGNBXGI4DMNRQGSQXMAQ).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
b8acf7c to
c0f8832
Compare
|
Took a bit longer than I initially expected, but libc got released with the QNX related changes! Sorry for the delay |
I didn't actually understood last time. But |
We won't need a license for running |
When working with socket2 on more modern QNX8 targets (with io-sock networking stack), I noticed the crate does not compile because of some missing cfgs, which are caused by this change in the rustc:
rust-lang/rust#158449
This PR requires some extra changes to be merged in the libc crate to actually work:
https://github.com/rust-lang/libc/pull/5469/changes
Notably, this change does not affect QNX7 with io-sock networking stack, which I think compiles but is quite broken. netinet headers include a lot of changes in io-sock (as they rebased on a new BSD version), so it's definitely using bad constants for some things.