Skip to content

feat: add qnx7.1 (io-pkt/io-sock) and qnx8 check - #677

Merged
Thomasdezeeuw merged 3 commits into
rust-lang:masterfrom
lambinoo:feat-cargo-check-qnx
Oct 9, 2026
Merged

Thomasdezeeuw merged 3 commits into
rust-lang:masterfrom
lambinoo:feat-cargo-check-qnx

Conversation

@lambinoo

@lambinoo lambinoo commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Following guidance in #670, I'm adding a cargo check for the main QNX targets. To avoid exploding the number of QNX related jobs, this only focuses on ARM targets. It's QNX's main target anyway, since it targets automotive. It should be enough to cover most important targets:

  • io-sock QNX7.1
  • io-pkt QNX7.1
  • QNX8 (implicitly io-sock)

There's three commits in this PR:

  1. Enable cargo check
  2. to fix a rustdoc build error, adds cloexec support to QNX targets since it is supported anyway
  3. Fix an oversight on my part with IPV6 multicast. Thanks cargo check! Sorry for that

I can split the other two in a different PR if it's preferred.

@lambinoo
lambinoo force-pushed the feat-cargo-check-qnx branch 3 times, most recently from e80c34f to 0ad02c1 Compare October 9, 2026 15:02
@lambinoo
lambinoo force-pushed the feat-cargo-check-qnx branch from 0ad02c1 to 950cb8d Compare October 9, 2026 15:12
@lambinoo
lambinoo marked this pull request as ready for review October 9, 2026 15:31
@Thomasdezeeuw
Thomasdezeeuw marked this pull request as draft October 9, 2026 15:40
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

Let me know when this passes the CI :)

@lambinoo

lambinoo commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

I think it's all green (at least, as far as I can make it.., so technically not green). It's only thumbv8m.main-nuttx-eabihf that seems to be broken, and that one was failing in the other QNX PRs I think too.

Probably something that got removed from libc in the latest version?

Edit: seems to fail when it compiles libstd, so i'm guessing this is something that needs to get fixed in libc and backported into rust-lang/rust?

Comment thread src/sys/unix.rs Outdated
pub(crate) use libc::{
IPV6_JOIN_GROUP as IPV6_ADD_MEMBERSHIP, IPV6_LEAVE_GROUP as IPV6_DROP_MEMBERSHIP,
};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you revert this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be reverted!

@Thomasdezeeuw
Thomasdezeeuw marked this pull request as ready for review October 9, 2026 15:55
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

The CI wasn't green when I opened the page, must have been fixed before I let a comment. You can ignore nuttx.

@lambinoo
lambinoo force-pushed the feat-cargo-check-qnx branch from 84f99ab to 70c16c8 Compare October 9, 2026 16:02
@Thomasdezeeuw
Thomasdezeeuw merged commit 49d7a2f into rust-lang:master Oct 9, 2026
57 of 58 checks passed
@Thomasdezeeuw

Copy link
Copy Markdown
Collaborator

Thanks @lambinoo

@lambinoo

lambinoo commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks to you too! Have a great day/evening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants