Skip to content

Let owners and workspace admins add people to unbridged rooms in Console - #2146

Open
rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:feat/console-add-people-to-unbridged-rooms
Open

rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:feat/console-add-people-to-unbridged-rooms

Conversation

@rudycelekli

Copy link
Copy Markdown

Addresses the Console path in #2123. A private room made from a template without a messaging app can hold Switch members, but its Add people control requires a bridge. This made it impossible to use Console to let another workspace member into the room.

Use the workspace roster and the existing /chats/{room_id}/members endpoint for unbridged template and room views. The control follows the endpoint's owner and workspace-admin check, excludes archived rooms, and names the room's workspace explicitly during membership reads and writes. The returned membership list updates the people fold. Bridged rooms continue to use their platform roster, and the MCP tool contract is unchanged.

Validation: the two Add people visibility regressions failed with the original renderer. On the proposed change, 32 Chromium tests and 27 Node tests passed, including a Switch-ID add, roster refresh, and negative authorization and archive checks. Console TypeScript, focused lint and formatting, and git diff checks passed. Backend integration and the full repository suites were not run.

Codex assisted with this change and its tests.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Before we can merge it, please read our Contributor License Agreement and sign it by posting the following comment on this pull request:


Contributing on behalf of a company? Your employer can sign the Corporate CLA instead: complete the PDF with your authorized GitHub usernames, have an authorized representative sign it, and email it to legal@sandboxquantum.com. Once we record it, your contributions are recognized as covered — see CONTRIBUTING.md.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant