Skip to content

Let agents invite people into unbridged rooms for their managers - #2156

Open
rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:feat/agent-tool-invite-native-room-people
Open

rudycelekli wants to merge 1 commit into
sandbox-quantum:mainfrom
rudycelekli:feat/agent-tool-invite-native-room-people

Conversation

@rudycelekli

Copy link
Copy Markdown

Part of #2123. This covers the agent tool. #2146 handles the desktop affordance using the existing chat route.

The agent's add_users_to_room operation currently rejects every room without a messaging app. Give that path the same manager boundary as Console's native invite endpoint: the agent's owner must own the room or administer its workspace. Resolve exact Switch names or email addresses through the existing chat membership service and report unresolved names. A mere room member cannot use this to share the room. Bridged rooms and fixed-membership conversations use their existing rules.

A real PostgreSQL fixture reproduced the refusal on main. With the patch, both an owner and a workspace admin can add a workspace member, an unrelated member agent is refused, and names outside the workspace remain unresolved. All 30 focused chat, roster authorization, telemetry, and tool surface tests passed on macOS using isolated PostgreSQL 18.6. Full Ruff format/lint and mypy passed. The full Docker-backed test suite was not run.

Codex assisted with implementation and validation.

@github-actions

Copy link
Copy Markdown

Thank you for your contribution! Before we can merge it, please read our Contributor License Agreement and sign it by posting the following comment on this pull request:


Contributing on behalf of a company? Your employer can sign the Corporate CLA instead: complete the PDF with your authorized GitHub usernames, have an authorized representative sign it, and email it to legal@sandboxquantum.com. Once we record it, your contributions are recognized as covered — see CONTRIBUTING.md.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant