Repository navigation
Conversation
… ComputeCreateDSHash Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
…ash presence checks Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Remove Sync.Validate, Buffer and WriteWorkers: nothing read them, and validation runs per transaction on the tree. Drop the unused ComputeCreateDSHash. Add api.GNMIEncoding; unknown or numeric encodings are rejected and a gNMI sync without an encoding inherits the target's. go.mod temporarily replaces sdc-protos with the commit that reserves the removed Sync fields. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
config-server hashes the resolved DatastoreSpec plus referenced object versions to decide when to recreate a datastore. Restore it without the removed Sync fields and with the typed gNMI encoding, and document why the hash is defined over DatastoreSpec. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
steiler
force-pushed
the
feat/api-types
branch
from
November 11, 2026 11:02
32a693d to
2d2161f
Compare
Replace the Entries slice with Path, Expected and Current to match the per-deviation WatchDeviationResponse, drop DeviationEntry and document DeviationReasonIntentExists as an intent marker rather than a reason. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Only config-server compares datastore hashes to decide when to recreate a datastore, and its extra inputs are Kubernetes resource versions. The data server never computes or compares a hash, so it does not belong in pkg/api. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
CONFIG is sent as gNMI encoding 45. The typed encoding rejects numeric values, so name it explicitly and resolve it in the gNMI encoding parsers. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR A of the single-binary stack (ticket 01).
Adds the types-only
pkg/apipackage (no gRPC or internals imports):DatastoreSpec,DatastoreInfo,TxRef,Intent/Update/Delete,Origin,Format, schema admin types,DeviationEventapi.IsRetryableComputeCreateDSHashover a canonical form ofDatastoreSpecAdditive only; nothing imports the package yet and the standalone server is unchanged.
Notes:
datastore.ErrDatastoreLocked/targettypes.ErrNotConnected; that comes with the core constructor PR.Tests:
go test ./pkg/apicoversIsRetryable,errors.Ismatching and hash stability, including a check that every spec field changes the hash.