Repository navigation
Conversation
steiler
force-pushed
the
feat/core-constructor
branch
from
November 9, 2026 09:59
66b143d to
de21566
Compare
steiler
force-pushed
the
feat/core-constructor
branch
3 times, most recently
from
November 11, 2026 10:49
e58f6d1 to
1f8d04a
Compare
steiler
force-pushed
the
feat/core-constructor
branch
from
November 11, 2026 11:02
1f8d04a to
1a8ff0d
Compare
steiler
force-pushed
the
feat/core-constructor
branch
from
November 11, 2026 12:37
1a8ff0d to
5eafb7f
Compare
…DataStore Adds pkg/core, which builds the schema store, cache and datastores from a *config.Config without a gRPC listener or peer. GetDataStore returns api.DatastoreInfo and maps unknown/empty names to api sentinels. WatchDeviations fixes the channel API shape. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
…and errors Names the core logger data-server, validates the datastore name in one place, drops the error alias and documents swallowed errors. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
steiler
force-pushed
the
feat/core-constructor
branch
from
November 11, 2026 12:49
5eafb7f to
1b262a1
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #534 (PR A); retarget to main once A lands.
What
pkg/core:New,Start,Stop(idempotent),WaitReady,WithDialOptions.GetDataStoreruns end to end through the core withpkg/apitypes (credentials redacted in the returned spec).WatchDeviations(ctx, name) (<-chan api.DeviationEvent, error)fixes the API shape; it emits no events yet.Startreturns an error instead of callingos.Exit, and fails if a configured initial datastore cannot be created (previously logged and ignored).Tests
Go test constructs the core from a
*config.Config, waits ready and callsGetDataStorewith no gRPC or peer.go test ./...passes.Notes
pkg/serveris untouched; schema/cache init is duplicated until the grpcserver adapter ticket.go test -race ./pkg/corehits an existing race inpkg/datastore(Datastore.sbiwritten in the connect goroutine, read inStop).