Repository navigation
Conversation
steiler
force-pushed
the
feat/core-rpcs
branch
from
November 9, 2026 15:43
9dff3db to
3147c17
Compare
steiler
force-pushed
the
feat/core-rpcs
branch
from
November 9, 2026 15:56
3147c17 to
51913cb
Compare
steiler
force-pushed
the
feat/core-rpcs
branch
from
November 11, 2026 10:49
d702729 to
08f32b5
Compare
steiler
force-pushed
the
feat/core-rpcs
branch
from
November 11, 2026 11:02
08f32b5 to
85e5d5f
Compare
steiler
force-pushed
the
feat/core-rpcs
branch
from
November 11, 2026 12:37
85e5d5f to
43f3539
Compare
Add CreateDataStore, DeleteDataStore, TransactionSet/Confirm/Cancel, GetIntent, BlameConfig, WatchDeviations and schema details/create/delete to Core without any peer or gRPC dependency; Origin replaces the peer. Share the datastore-locked and not-connected sentinels with pkg/api so errors.Is and api.IsRetryable match them. Deviation watchers get a bounded channel: a full channel blocks the producer, a send blocked for 30s logs a warning, and a duplicate START is ignored. The datastore takes a DeviationSink instead of a gRPC stream. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Add Datastore.IntentToInternalTI and share the flag and expansion logic with the gRPC path through buildTransactionIntent. Explicit delete paths that do not parse now fail with ErrInvalidArgument instead of being skipped. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
Blame and deviation trees may omit values on container nodes; ToString on nil panicked in TestTransactionLifecycleWithoutPeer. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
DeviationEvent carries one path per event; set Path, Expected and Current directly instead of an Entries slice. Signed-off-by: Markus Vahlenkamp <markus.vahlenkamp@nokia.com>
steiler
force-pushed
the
feat/core-rpcs
branch
from
November 11, 2026 12:49
43f3539 to
9d0f793
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #535. Adds the remaining in-process RPCs to pkg/core.