Skip to content

Ignore Duplicate email addresses - #739

Closed
saurabhrajguru wants to merge 5 commits into
sendgrid:masterfrom
saurabhrajguru:saurabhrajguru691duplicatemailids
Closed

saurabhrajguru wants to merge 5 commits into
sendgrid:masterfrom
saurabhrajguru:saurabhrajguru691duplicatemailids

Conversation

@saurabhrajguru

@saurabhrajguru saurabhrajguru commented Sep 11, 2018 •

Copy link
Copy Markdown

Fixes #691

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This fix Ignores adding duplicate email addresses in To,CC and BCC.
  • This fix will only take unique email addresses.
  • This fix is implemented on EmailHelpers as well as SendGridMessage Methods.
  • Apart from that this also adds "LambdaComparer" in Helper-Utilities.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 11, 2018
@SendGridDX

SendGridDX commented Sep 11, 2018 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@saurabhrajguru

Copy link
Copy Markdown
Author

I missed one more thing.
So this one is WIP right now.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: hard fix is hard in difficulty status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Sep 15, 2018
@saurabhrajguru

Copy link
Copy Markdown
Author

@thinkingserious I believe this is working fine.
I have added tests to verify that.
Please review and let me know if there is any feedback.

Thanks

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio hacktoberfest and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 5, 2018
@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @saurabhrajguru,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious

Copy link
Copy Markdown
Contributor

Hello @saurabhrajguru,

Thanks again for the PR!

You have earned 7 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at dx+hacktoberfest2018@sendgrid.com.

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino

Copy link
Copy Markdown
Contributor

Closing in favor of #991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No email is sent when recipient email is duplicated

4 participants