Repository navigation
feat: ignore duplicate email addresses when serializing the message - #991
Merged
Merged
Conversation
This was referenced Apr 13, 2020
aevitas
approved these changes
Apr 13, 2020
aevitas
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Interesting approach, wouldn't directly have considered using a JsonSerializer to deduplicate them, but I suppose it's the best way to do it without adding too much code.
Contributor
Author
|
Yeah, first thought was to switch the emails to be stored in a hash set, but would cause some breakages depending on use. This is probably the least breaking, simplest approach. |
eshanholtz
approved these changes
Apr 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #691
Closes #939
Closes #739