Skip to content

feat: ignore duplicate email addresses when serializing the message - #991

Merged
childish-sambino merged 1 commit into
masterfrom
duplicate-emails
Apr 13, 2020
Merged

childish-sambino merged 1 commit into
masterfrom
duplicate-emails

Conversation

@childish-sambino

Copy link
Copy Markdown
Contributor

Fixes #691
Closes #939
Closes #739

@aevitas aevitas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Interesting approach, wouldn't directly have considered using a JsonSerializer to deduplicate them, but I suppose it's the best way to do it without adding too much code.

@childish-sambino

Copy link
Copy Markdown
Contributor Author

Yeah, first thought was to switch the emails to be stored in a hash set, but would cause some breakages depending on use. This is probably the least breaking, simplest approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No email is sent when recipient email is duplicated

4 participants