Skip to content

Duplicate checking when adding email to personalization is not accurate #445

Closed

Description

@tmimura39

Issue Summary

About the duplicate check added by #437
It's not accurate to be case insensitive.

Steps to Reproduce

  1. Add uppercase email
  2. Add duplicate uppercase email
  3. No DuplicatePersonalizationError occurs
  4. Request processing runs and 400 is returned

Activity

  1. childish-sambino commented on Nov 2, 2020

    @childish-sambino
    Contributor

    This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

  2. clinejj commented on Jan 1, 2021

    @clinejj

    A suggested improvement could be to manually de-duplicate rather than raising an error. The python and C# libraries are adding this functionality:
    sendgrid/sendgrid-python#788
    sendgrid/sendgrid-csharp#991

    (I admittedly didn't know that SendGrid would bounce an email back and am receiving this error, when I would rather just have the duplicates removed and the email sent)

  3. netwire88 commented on Jan 20, 2021

    @netwire88

    I also have the same problem, if the same email address is in to and cc, then SendGrid::DuplicatePersonalizationError is raised.

  4. netwire88 commented on Feb 24, 2021

    @netwire88

    @JenniferMah Hi, I'm using the latest build and having issues with 2 related scenarios:

    1. upper vs. lower case - if I have test1@example.com and TEST1@EXAMPLE.COM, that doesn't work
    2. to/cc/bcc fields - if I have test1@example.com in to field and cc field, then it doesn't work. Similarly with to and bcc, and cc & bcc
  5. JenniferMah commented on Feb 24, 2021

    @JenniferMah
    Contributor

    Hi @netwire88
    Could you please open a new issue with this information?

  6. netwire88 commented on Feb 24, 2021

    @netwire88

    Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugbug in the library

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions