Implement fastpair#142
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## development #142 +/- ##
===============================================
+ Coverage 83.39% 83.71% +0.32%
===============================================
Files 78 80 +2
Lines 8377 8591 +214
===============================================
+ Hits 6986 7192 +206
- Misses 1391 1399 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
Author
|
Implemented benchmark: |
morenol
reviewed
Aug 18, 2022
morenol
reviewed
Aug 20, 2022
morenol
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I added a couple of comments
morenol
reviewed
Aug 20, 2022
Mec-iS
force-pushed
the
implement-fast-pair
branch
from
August 21, 2022 16:22
f2666be to
5073d7f
Compare
morenol
pushed a commit
that referenced
this pull request
Nov 8, 2022
* initial fastpair implementation * FastPair initial implementation * implement fastpair * Add random test * Add bench for fastpair * Refactor with constructor for FastPair * Add serialization for PairwiseDistance * Add fp_bench feature for fastpair bench
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract what is working from #17:
These features can be used in the future to implement additive clustering or other novel features.
may be of interest for @danieljrmay