Repository navigation
Enhancement: Include assessment with answers in submission - #1059
Merged
RichDom2185 merged 14 commits intoFeb 21, 2024
Merged
RichDom2185 merged 14 commits into
RichDom2185 merged 14 commits into
Conversation
GabrielCWT
commented
Feb 2, 2024
GabrielCWT
commented
Contributor
- Update get_answers_in_submission to query for the assessment for the submission
- Update admin_grading_controller to accept assessment and answers from SQL query
- Implement admin_grading_view assessment.json template
- Update admin_grading_view show.json template
GabrielCWT
changed the title
GabrielCWT
force-pushed
the
enhancement/answers-and-assessment
branch
2 times, most recently
from
February 2, 2024 15:48
a1b4268 to
f4fa55b
Compare
GabrielCWT
force-pushed
the
enhancement/answers-and-assessment
branch
from
February 2, 2024 15:55
f4fa55b to
61b175f
Compare
RichDom2185
reviewed
Feb 7, 2024
RichDom2185
left a comment
RichDom2185
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for working on this! Just a minor comment below, but otherwise, LGTM! Though we need to wait for the other team to prepare the corresponding frontend PR before we can merge this….
This was referenced Feb 12, 2024
sayomaki
force-pushed
the
enhancement/answers-and-assessment
branch
from
February 21, 2024 06:05
6135f91 to
315d83a
Compare
lhw-1
pushed a commit
to source-academy/frontend
that referenced
this pull request
Feb 21, 2024
* Added briefing (long summary) to Grading (#2310) * Updated grading briefing to be inline with backend's camelCase * resolve on some type conflicts * fix for TypeError on test action * Added subtype for GradingQuery with GradingAssessment; added GradingMock data; code cleanup * resolved edited export type Updates the grading query fetched from the backend to include the assessment briefing, as per changes made in source-academy/backend#1059. Also includes a new tab to view briefings during grading.
RichDom2185
approved these changes
Feb 21, 2024
melnyk1997
pushed a commit
to melnyk1997/frontend-academy
that referenced
this pull request
Feb 15, 2025
* Added briefing (long summary) to Grading (source-academy#2310) * Updated grading briefing to be inline with backend's camelCase * resolve on some type conflicts * fix for TypeError on test action * Added subtype for GradingQuery with GradingAssessment; added GradingMock data; code cleanup * resolved edited export type Updates the grading query fetched from the backend to include the assessment briefing, as per changes made in source-academy/backend#1059. Also includes a new tab to view briefings during grading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.