Skip to content

Grading: Viewable Assessment Briefings - #2783

Merged
lhw-1 merged 31 commits into
source-academy:masterfrom
InfinityTwo:grading-briefing
Feb 21, 2024
Merged

Grading: Viewable Assessment Briefings#2783
lhw-1 merged 31 commits into
source-academy:masterfrom
InfinityTwo:grading-briefing

Conversation

@InfinityTwo

@InfinityTwo InfinityTwo commented Feb 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

We've added a tab to view the briefings (long summary) inside the assessment for grading that resolves #2310

Note

  • This pull request requires this pull request in the backend to be compatible - Enhancement: Include assessment with answers in submission  backend#1059
  • The implementation changes the redux state of grading due to a new query response format from the backend API.
  • It may break code that uses the interfaces of GradingAnswers (previously known as Grading) and GradingQuery, but I have tested it as much as possible.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  • Install the required backend PR
  • Open Source Academy and go to Grading
  • Grade any of the assessments
  • There should be a new tab on the UI that allows you to see the briefing (see screenshot below)

Grading Briefing Preview

Checklist

  • I have tested this code
  • I have updated the documentation

InfinityTwo and others added 23 commits February 7, 2024 18:18
@InfinityTwo
Added briefing (long summary) to Grading (source-academy#2310)
c445d9f
@InfinityTwo
Added briefing (long summary) to Grading (source-academy#2310)
c56f548
@InfinityTwo
Updated grading briefing to be inline with backend's camelCase
a0e7696
@InfinityTwo
Merge branch 'master' of https://github.com/InfinityTwo/sourceacademy…
1ab2305 
…-frontend into grading-briefing
@InfinityTwo
cleanup code
8357342
@InfinityTwo
Merge branch 'master' of https://github.com/InfinityTwo/sourceacademy…
59c98ce 
…-frontend into HEAD
@InfinityTwo
cleanup code
8195cb1
@InfinityTwo
Merge branch 'grading-briefing' of https://github.com/InfinityTwo/sou…
9e9449e 
…rceacademy-frontend into HEAD
@InfinityTwo
removal of accidental commit of package-lock and prettierignore
21a212b
@renovate @InfinityTwo
Update dependency npm-run-all2 to v6 (source-academy#2770)
4f6cb9c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @InfinityTwo
Update dependency eslint-plugin-simple-import-sort to v11 (source-aca…
8d63df3 
…demy#2769)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Zenkoh1 @RichDom2185 @InfinityTwo
Enable Stepper for Typed Variant (source-academy#2766)
e01c64f 
* Enable Stepper for Typed Variant

* Fix format

* Modify CI tests, enabling Stepper tool for Typed Variant

---------

Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
@renovate @InfinityTwo
Update dependency eslint-plugin-simple-import-sort to v12 (source-aca…
138b215 
…demy#2771)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@RichDom2185 @sayomaki @InfinityTwo
Upgrade to Blueprint v5 (source-academy#2718)
34b8cde 
* Replace deprecated `ITreeNode` with `TreeNodeInfo`

Done as per migration guide.

* Upgrade BlueprintJS dependencies to v5

* Use public `IconName` type instead of internal API

Fixes a compile error following the version upgrade.

* Migrate to `Datetime2` package

Resolves the issue with the deprecated `DateInput` component. Also made
the necessary API changes for the migration.

* Update prop name

Fixes the breaking change introduced by the Blueprint v5 upgrade.

* Update test snapshots

* Reran `yarn install` post-merge

* Update snapshots post-merge

* Update SCSS namespace

* Fix popover styles

Update the target classes to match the new components.

* Revert Env Vizualiser snapshot change

* Fix TreeNode comparison to compare id instead of object reference

---------

Co-authored-by: sayomaki <sayomayomaki@gmail.com>
@InfinityTwo
cleanup code
52d49ff
@InfinityTwo
cleanup code
2d4d8e4
@InfinityTwo
removal of accidental commit of package-lock and prettierignore
5e0291e
@InfinityTwo
Merge branch 'grading-briefing' of https://github.com/InfinityTwo/sou…
b2316aa 
…rceacademy-frontend into grading-briefing
@InfinityTwo
resolve on some type conflicts
1c5d47d
@InfinityTwo
Merge branch 'source-academy:master' into grading-briefing
87d2d9e
@InfinityTwo
Merge branch 'source-academy:master' into grading-briefing
5eba8e5
@InfinityTwo
fix for TypeError on test action
26d5e46
@InfinityTwo
Merge branch 'source-academy:master' into grading-briefing
b30299f
@InfinityTwo InfinityTwo self-assigned this Feb 14, 2024
@coveralls

coveralls commented Feb 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7984433971

Details

  • -20 of 26 (23.08%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 37.003%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/mocks/GradingMocks.ts 4 5 80.0%
src/commons/sagas/RequestsSaga.ts 1 3 33.33%
src/commons/mocks/BackendMocks.ts 0 4 0.0%
src/commons/sagas/BackendSaga.ts 0 4 0.0%
src/pages/academy/grading/subcomponents/GradingWorkspace.tsx 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/commons/mocks/BackendMocks.ts 1 13.5%
src/commons/sagas/RequestsSaga.ts 1 13.31%
Totals Coverage Status
Change from base Build 7982906712: 0.002%
Covered Lines: 5735
Relevant Lines: 14582
💛 - Coveralls

@InfinityTwo
InfinityTwo marked this pull request as ready for review February 14, 2024 12:29
lhw-1
lhw-1 reviewed Feb 18, 2024
View reviewed changes

@lhw-1 lhw-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @InfinityTwo! The changes for the new query response format are pretty straightforward & we can maybe include an image for the PR, but otherwise, LGTM.

Comment thread src/commons/mocks/BackendMocks.ts Resolved
Comment thread src/features/grading/GradingTypes.ts Resolved
Comment thread src/pages/academy/grading/subcomponents/GradingWorkspace.tsx Resolved
lhw-1
lhw-1 approved these changes Feb 21, 2024
View reviewed changes

@lhw-1 lhw-1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lhw-1 lhw-1 changed the title Grading: Viewable Assessment Briefings (Re) Grading: Viewable Assessment Briefings Feb 21, 2024
@lhw-1
lhw-1 merged commit dd641c4 into source-academy:master Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhw-1 lhw-1 lhw-1 approved these changes
@RichDom2185 RichDom2185 Awaiting requested review from RichDom2185

Assignees

@InfinityTwo InfinityTwo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Grading: Assessment briefing not accessible while grading

5 participants

@InfinityTwo @coveralls @lhw-1 @Zenkoh1 @RichDom2185