Repository navigation
Clean up team assessments - #2875
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 8436849250Details
💛 - Coveralls |
This was referenced Mar 26, 2024
Merged
But also retained the functional component aspect.
Favors the use of Blueprint components over custom components and styles for a more consistent user interface.
The filters never belonged there in the first place as it is not a workspace. The functionality is not restored as we will be moving back to AG Grid for tables.
RichDom2185
force-pushed
the
clean-up-team-assessments
branch
from
March 26, 2024 13:31
5b4803f to
f8e4ba9
Compare
RichDom2185
marked this pull request as ready for review
March 26, 2024 13:31
RichDom2185
commented
Mar 26, 2024
RichDom2185
left a comment
RichDom2185
left a comment
Member
Author
There was a problem hiding this comment.
Can't approve my own PR, though, LGTM – as per offline discussions.
2 of 7 tasks
izruff
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Migrate Ground Control back to AG-Grid But also retained the functional component aspect. * Delete unused component * Use selectors for Ground Control state * Remove ground control from file system * Remove unnecessary styles Favors the use of Blueprint components over custom components and styles for a more consistent user interface. * Remove remaining traces of old Ground Control * Fix format * Remove team formation from workspace slice The filters never belonged there in the first place as it is not a workspace. The functionality is not restored as we will be moving back to AG Grid for tables.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To rebase and force-push following the merge of #2548.
Breaking change by technicality.
Summary of changes:
More cleanup will be done in the future.
Type of change
How to test
Checklist