Repository navigation
Fix and Improve Ground Control - #2881
Closed
RichDom2185 wants to merge 15 commits into
Closed
RichDom2185 wants to merge 15 commits into
RichDom2185 wants to merge 15 commits into
Conversation
The mutable state should have been migrated to use `useRef` when the component was transitioned to a functional component.
Pull Request Test Coverage Report for Build 9052848283Details
💛 - Coveralls |
Contributor
|
For some reason the table still looks the way it does. We might need to take a closer look at it |
Member
Author
Hmm, I see, alright, I'll take a closer look over the next few days. Thanks! |
RichDom2185
marked this pull request as draft
March 26, 2024 17:20
RichDom2185
changed the title
3 of 6 tasks
Member
Author
The issue is now fixed in #3001. But I'm keeping this PR open for some further improvements. |
martin-henz
added a commit
that referenced
this pull request
Mar 6, 2026
The mutable gridApi variable was lost on every re-render after the component was converted to a functional component. Migrate to useRef to persist the reference correctly. Also removes the Redux connect() container (GroundControlContainer) in favour of calling useDispatch() directly in the component, consistent with the rest of the codebase. Revives #2881 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks done
Member
|
Superseded by #3637 |
Member
Author
|
Will close if actually superseded |
RichDom2185
added a commit
that referenced
this pull request
May 13, 2026
…iner (#3637) * Fix Ground Control grid API regression by migrating to useRef The mutable gridApi variable was lost on every re-render after the component was converted to a functional component. Migrate to useRef to persist the reference correctly. Also removes the Redux connect() container (GroundControlContainer) in favour of calling useDispatch() directly in the component, consistent with the rest of the codebase. Revives #2881 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Fix infinite re-render loop in Ground Control Two causes identified: - onGridSizeChanged calling sizeColumnsToFit() created a feedback loop (resize → sizeColumnsToFit → resize → ...). Removed the handler. - columnDefs being redefined on every render caused AG Grid to re-process columns each cycle. Wrapped in useMemo([dispatch]) so it is only computed once (dispatch from useDispatch is stable). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * style: format GroundControl.tsx * Fix most errors post-merge * Fix error post-merge --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mutable state should have been migrated to use
useRefwhen the component was transitioned to a functional component.This was a regression introduced in #2875.
Type of change
How to test
It should now work, aka fixes this bug:
Checklist