Repository navigation
engine: refuse removeDuplicates with no valid column instead of deleting all rows - #1308
Merged
aiongg merged 1 commit intoOct 22, 2026
Conversation
jesusthehelper-oss
added a commit
to jesusthehelper-oss/gridcraft
that referenced
this pull request
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the audit described in the companion issue (findings, reachability arguments, and patches for the remaining defects are filed there).
What this fixes
GridCraft: minimal fix with a regression test, generated from the audit at
d9d09f0and applied on top of currentmain.Verification
Regression test included (
remove_duplicates_without_a_valid_column_is_refused), verified locally:cargo xtask cishould confirm the full gate.Fixes #1307 (finding 2; the issue carries patches for findings 1, 3, 4).