Repository navigation
Conversation
Parse every requested comparison column before editing the workbook so malformed entries cannot silently narrow the duplicate key and discard distinct rows.
Cover mixed valid and malformed columns without workbook, selection, undo, redo or dirty-state changes. Preserve named columns, relative numeric offsets and the omitted default.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Apply the exact formatting correction reported by cargo fmt in the hosted CI gate.
Upstream PR: storytold#4286 Head: 9be29b0
Merges the zcode-pr-transfer branch (61 commits transferring open, not-yet-merged upstream PRs into our fork) into main. Docs (docs/ui-parity.md, docs/file-format-parity.md) resolved in favor of main's current changelog state; code from all transferred PRs carried over cleanly. Commits carried over (21 from this session + 40 earlier transfers): storytold#4408, storytold#4405, storytold#4406, storytold#4386, storytold#4379, storytold#4378, storytold#4376, storytold#4375, storytold#4373, storytold#4370, storytold#4369, storytold#4348, storytold#4347, storytold#4345, storytold#4344, storytold#4343, storytold#4341, storytold#4340, storytold#4337, storytold#4336, storytold#4318, storytold#4316, storytold#4315, storytold#4312, storytold#4310, storytold#4307, storytold#4306, storytold#4305, storytold#4303, storytold#4298, storytold#4295, storytold#4287, storytold#4286, storytold#4257, storytold#4256, storytold#4254, storytold#4252, storytold#4251, storytold#4248, storytold#4244, storytold#4243, storytold#4229, storytold#4228, storytold#4227, storytold#4225, storytold#4221, storytold#4220, storytold#4219, storytold#4217, storytold#4424, storytold#4423, storytold#4420, storytold#4419, storytold#4418, storytold#4414, storytold#3617, storytold#2642, storytold#2556, storytold#2321
Summary
data.removeDuplicatessilently discarded malformed entries fromcolumns. With equal values in B and distinct values in C,columns: ["B", "???"]compared only B and deleted a distinct row. Parse every supplied array entry before editing and return the existing column error if any entry is invalid. Named columns, numeric offsets and the omitted default keep their current behavior.Validation
Added regressions for mixed malformed entries, unchanged workbook/selection/undo/redo/dirty state after refusal, and valid named or relative columns. Checked current main and competing Remove Duplicates changes, including the earlier empty-column guard in #1308, and reviewed the complete two-file diff.
Neither
cargonorrustcis available in this environment. The regressions andcargo xtask ciwere not run locally. Hosted CI passed one42dbfc4f04d5b8ebdbff7a911b38c88255b67e1: four successful checks and two skipped coverage jobs. CodeRabbit reported no actionable comments.Summary by CodeRabbit