Skip to content

fix(engine): reject malformed explicit outline ranges - #4227

Open
MMexicann wants to merge 2 commits into
storytold:mainfrom
MMexicann:patch-28
Open

MMexicann wants to merge 2 commits into
storytold:mainfrom
MMexicann:patch-28

Conversation

@MMexicann

@MMexicann MMexicann commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Malformed explicit rows/cols strings silently fell back to the current selection for Group, Ungroup, Hide Detail and Show Detail. Reject unparsable supplied ranges before changing outline state. Valid cell ranges and the omitted-range selection fallback remain supported.

Adds regressions for unchanged workbook, selection and history across all four commands, plus valid range/default cases. Checked current source and outline PRs: protection checks #3296 are merged, and open no-op handling #3227 retains the invalid-range fallback. Patch/test APIs were independently reviewed. No local Rust toolchain is available, so the regression and cargo xtask ci have not been run locally. Hosted CI passed on 34393ce11090c9ecc5efacde14c2296e4b92aed1: three successful checks, one neutral check and two skipped coverage jobs.

Add test for invalid outline ranges to ensure selection fallback is not triggered. Validates that the document state remains unchanged on bad parameter execution.
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 23 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f204433 and 34393ce.

Files selected for processing: 2

  • crates/engine/src/cmd/data/grouping.rs
  • crates/engine/src/cmd/data/tests.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

emrahoksak pushed a commit to emrahoksak/girdcraft- that referenced this pull request Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant