Repository navigation
Conversation
Use the Go To range-name resolver for dropdown entries, including foreign sheet scopes and non-range filtering. Build the list only while the popup is open.
Exercise the actual dropdown with same-named workbook and foreign sheet ranges, exclude a constant, and click the qualified local name to verify navigation.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Apply the exact array-layout correction reported by cargo fmt in hosted CI.
Upstream PR: storytold#4287 Head: b869c7c
Merges the zcode-pr-transfer branch (61 commits transferring open, not-yet-merged upstream PRs into our fork) into main. Docs (docs/ui-parity.md, docs/file-format-parity.md) resolved in favor of main's current changelog state; code from all transferred PRs carried over cleanly. Commits carried over (21 from this session + 40 earlier transfers): storytold#4408, storytold#4405, storytold#4406, storytold#4386, storytold#4379, storytold#4378, storytold#4376, storytold#4375, storytold#4373, storytold#4370, storytold#4369, storytold#4348, storytold#4347, storytold#4345, storytold#4344, storytold#4343, storytold#4341, storytold#4340, storytold#4337, storytold#4336, storytold#4318, storytold#4316, storytold#4315, storytold#4312, storytold#4310, storytold#4307, storytold#4306, storytold#4305, storytold#4303, storytold#4298, storytold#4295, storytold#4287, storytold#4286, storytold#4257, storytold#4256, storytold#4254, storytold#4252, storytold#4251, storytold#4248, storytold#4244, storytold#4243, storytold#4229, storytold#4228, storytold#4227, storytold#4225, storytold#4221, storytold#4220, storytold#4219, storytold#4217, storytold#4424, storytold#4423, storytold#4420, storytold#4419, storytold#4418, storytold#4414, storytold#3617, storytold#2642, storytold#2556, storytold#2321
Summary
The Name Box dropdown displayed foreign sheet-local names without their scope and sent that bare name to Go To. A local name could fail to resolve from another sheet or navigate to a same-named workbook range.
Reuse the existing Go To range-name resolver so foreign names retain their quoted sheet scope, active-sheet shadowing is respected, and non-range names are excluded. Build the list inside the open popup.
Validation
Added a UI regression with workbook
Spot, local'Bob''s'!Spot, and constantRate. It checks distinct range choices, excludes the constant, and clicks the qualified entry to verify navigation to Bob's/D4. Current main, existing Go To tests, public APIs and the complete two-file diff were reviewed; the live Name Box PR search found no competing scope correction.Neither
cargonorrustcis available here. The UI regression, app rendering andcargo xtask ciwere not run locally. Hosted CI passed onb869c7c505eff5c6ddd060bd5836ec9818769bf1: four successful checks and two skipped coverage jobs. CodeRabbit reported no actionable comments; its separate Clippy tool did not complete.Summary by CodeRabbit