Skip to content

fix(engine): reject unknown subtotal functions - #4228

Open
MMexicann wants to merge 2 commits into
storytold:mainfrom
MMexicann:patch-29
Open

MMexicann wants to merge 2 commits into
storytold:mainfrom
MMexicann:patch-29

Conversation

@MMexicann

@MMexicann MMexicann commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

An unknown subtotal function such as averag silently selected SUM and inserted incorrect totals. Match sum explicitly and reject unrecognized function strings before changing the sheet; the omitted default remains sum.

Adds regressions for unchanged workbook, selection and history after typo/empty functions, plus valid average, explicit sum and omitted defaults. Checked current source and existing subtotal PRs; open grand-total outline PR #4184 retains the same unknown-function fallback. Patch/test APIs were independently reviewed. No local Rust toolchain is available, so the regression and cargo xtask ci have not been run locally. Hosted CI passed on 9be29b0bf9a72202d91f390719f176382ce37338: three successful checks, one neutral check and two skipped coverage jobs. CodeRabbit review remains limited by its OSS quota.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 8 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f204433 and 9be29b0.

Files selected for processing: 2

  • crates/engine/src/cmd/data/grouping.rs
  • crates/engine/src/cmd/data/tests.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

emrahoksak pushed a commit to emrahoksak/girdcraft- that referenced this pull request Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant