Skip to content

i18n(de): complete the German interface catalog - #3034

Open
DomiLuebben wants to merge 1 commit into
storytold:mainfrom
DomiLuebben:german-translations-complete
Open

DomiLuebben wants to merge 1 commit into
storytold:mainfrom
DomiLuebben:german-translations-complete

Conversation

@DomiLuebben

@DomiLuebben DomiLuebben commented Oct 31, 2026 •

Copy link
Copy Markdown

What

The German catalog (crates/ui-egui/src/i18n/de.rs) had 455 keys. The other catalogs share a set of 1,180, and the running interface shows 48 more that no catalog had. This adds all of them, so cargo xtask i18n-report lists 0 missing for German (455 → 1,228 keys, ~12% → ~56% of the estimated UI strings).

Covered: dialog labels and messages, tooltips, chart type and cell style names, number and border names, Solver, Analysis ToolPak, PivotTable and printing messages, macro editor steps, window arranging, Resize Table, and the update check results. Wording follows Excel's German terms (Zielwertsuche, Datenschnitt, Bedingte Formatierung, Zellenformatvorlagen, ...). Placeholders ({count}, {file}, ...) and \n line breaks are kept; the existing translations_keep_the_shape_of_their_english test passes.

How it was checked

  1. cargo xtask i18n-report for the keys other catalogs have.
  2. For labels no catalog has: ran the app in German with a temporary probe in Language::tr (not part of this PR) that logged every label without a translation, then opened every ribbon tab, all Backstage pages, 65 dialogs, the cell, header and sheet-tab context menus and the contextual Table Design and Chart Design tabs through the control channel. Everything that showed up in English is translated here.

Not covered: text that comes from the engine rather than the catalog (for example the placeholder in a new PivotTable), and states that need data this walkthrough did not create.

Tests

  • cargo test -p gridcraft-ui-egui --lib (249 passed), cargo fmt --check, cargo xtask i18n-report
  • docs/localization-parity.md: German row and revision history updated

The translations were drafted with an AI assistant and checked in the running app; a native-speaker review of the wording is welcome.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Expanded German translations across interface labels, dialogs, messages, tooltips, charts, printing, data analysis, and other areas. German coverage now includes about 56% of listed strings.
  • Documentation
    • Updated the localization coverage report with revised German coverage figures and a record of the expanded translation catalog.

The German catalog had 455 keys; the other catalogs share a set of 1,180 and the running UI
shows 48 more that no catalog had. Add them all: dialogs, tooltips, messages, chart and cell
style names, macro editor steps, window arranging, Resize Table and the update check results.

Found with `cargo xtask i18n-report`, then by running the app in German and logging every label
without a translation across the ribbon tabs, Backstage pages, dialogs, context menus and the
contextual Table and Chart tabs. Terms follow Excel's German wording.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 981fad1 and 78c70a2.

Files selected for processing: 2
  • crates/ui-egui/src/i18n/de.rs
  • docs/localization-parity.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The German translation catalog adds 789 English-to-German mappings. The localization parity document updates the reported German coverage, date, estimate, and revision history. Unmatched text continues to return None.

Changes: German localization

Layer / File(s) Summary
German translation coverage
crates/ui-egui/src/i18n/de.rs, docs/localization-parity.md
The German catalog adds 789 mappings for interface strings. The parity document updates coverage to 1,228 labels (~56%), lists dialogs, messages, and tooltips as covered, and records the catalog expansion.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: aiongg, echelon

Merge Risk: Minimal · up to 78c70

The catalog expansion appears mergeable, though the reported Find dialog translation gaps have not been independently verified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "i18n(de): complete the German interface catalog" matches the main change. The PR adds 789 English-to-German mappings to the German translate match in crates/ui-egui/src/i18n/de.rs, expandin…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "i18n(de): complete the German interface catalog" matches the main change. The PR adds 789 English-to-German mappings to the German translate match in crates/ui-egui/src/i18n/de.rs, expanding the catalog from 455 to 1,228 keys, and updates docs/localization-parity.md to match. The word "complete" overstates the scope slightly. The author says engine-provided text and states that need data not created during the walkthrough were not covered, so the catalog is not fully complete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReviewerA — source-read COMMENT (not an approval)

I read the first hunk: the German catalogue of the interface is a Rust file with a translate match, and about 800 lines are added in its middle, from " (password)" => " (Kennwort)" to the next entries, so the German interface becomes complete (the title). The visible rows follow the German conventions (Anführungszeichen „…“, "Kennwort" for password as Excel's German has it, "Keine Vorschläge"). I can't review 800 translations; a German speaker should check them against Excel's German terms, which users know (for functions, ribbon names and dialogs). A match over hundreds of string literals compiles slowly and cannot report a duplicate arm well (a duplicate is an unreachable pattern warning): check the build has no such warnings, and consider the table format the other apps use for catalogues. Add a test that lists the English keys with no German entry, and that every placeholder ({file}) appears in both. Nothing was run.

I ran nothing and have no exact-head CI result for this PR, so this is not an approval. Where a diff was long I read its code hunks rather than every generated or documentation line.

Status: waiting_author.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants