Skip to content

i18n: fill-handle and Home › Fill menu labels in every catalog - #4459

Open
FredApps wants to merge 1 commit into
storytold:mainfrom
FredApps:fix/i18n-fill-menu-labels
Open

FredApps wants to merge 1 commit into
storytold:mainfrom
FredApps:fix/i18n-fill-menu-labels

Conversation

@FredApps

@FredApps FredApps commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #4458.

The fill-handle menus showed English in every interface language. This adds the missing catalog rows:

  • All 18 non-English catalogs: the right-drag fill menu and Auto Fill Options entries (Copy Cells, Fill Series, Fill Formatting Only, Fill Without Formatting, Fill Days, Fill Weekdays, Fill Months, Fill Years), plus the button's own name, "Auto Fill Options".
  • Home › Fill menu: Series…, Down and Up in the nine catalogs that had no row for them (de, es, fr, ko, ru, sr, tr, vi, zh).
  • Ukrainian: the existing rows for Series…, Down and Up held the English text. They're now translated.

Each catalog's existing word for "fill" is kept, e.g. German ausfüllen, Dutch vullen, Romanian Umplere. Japanese adds its rows to EXTRA, the list for menu and pop-up labels, so CORE and DIALOGS keep their key sets. The translations were written from the plain meaning of the English. Native speakers haven't reviewed them yet, and their provenance is recorded in docs/localization-parity.md, as for earlier catalog changes.

Test. i18n::tests::fill_menu_labels_are_translated_in_every_catalog checks that every catalog has a non-empty, single-line, non-English row for each of these labels. It fails without this change (es: no row for "Copy Cells").

Ran locally (Linux):

  • cargo fmt --all -- --check
  • cargo clippy -p gridcraft-ui-egui --lib --locked -- -D warnings
  • cargo test -p gridcraft-ui-egui --lib --locked: 351 passed

I didn't run the full cargo xtask ci (integration tests, wasm), so I'm relying on CI for those.

Overlap. A few open catalog PRs add some of these keys to some languages: #2880, #3663, #2647, #2753, #3034, #4134 and #3258. Whichever lands second needs to drop the duplicate rows, or clippy will flag the unreachable match arms. #2628 adds Linear Trend and Growth Trend to the same menu and needs its own rows.

Summary by CodeRabbit

  • New Features
    • Added localized labels for cell copying, fill-series options, and fill directions across supported languages.
  • Tests
    • Added coverage to check that fill-menu labels are present and translated.
  • Documentation
    • Updated localization notes with the new translations and review status.

…told#4458)

The right-drag fill menu and the Auto Fill Options button (Copy Cells, Fill Series, Fill
Formatting Only, Fill Without Formatting, Fill Days, Fill Weekdays, Fill Months, Fill Years and
the button's own name) had no row in any catalog, so every language showed them in English.
Add them to all 18 non-English catalogs, add Series…, Down and Up from the Home › Fill menu to the
nine catalogs that lacked them, and translate the Ukrainian rows that held English.

fill_menu_labels_are_translated_in_every_catalog fails when one of these rows goes missing or
stays English.

Fixes storytold#4458

Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change adds fill-handle and Home › Fill translations to non-English catalogs. A test checks 12 labels across catalogs. The localization parity document records the updates and the translation review status.

Changes: Fill-menu localization

Layer / File(s) Summary
Add fill-menu translations
crates/ui-egui/src/i18n/*.rs
The non-English catalogs add translations for fill commands and options. Nine catalogs also add translations for “Series…”, “Down”, and “Up”; Ukrainian translations replace the English text for those labels.
Check catalog coverage
crates/ui-egui/src/i18n.rs, docs/localization-parity.md
A test checks that English returns each of 12 keys unchanged and that each non-English catalog returns a nonempty, single-line translation distinct from the key. The document records the coverage and translation review status.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related issues

  • storytold/gridcraft#3165 — This change adds Spanish translations for fill-menu labels, Series, Down, and Up. It does not address the wider Spanish catalog coverage gap.

Suggested reviewers: aiongg, vangel76

Merge Risk: Minimal · up to 60e9a

This adds translated labels for the fill menus and the Auto Fill Options button in all non-English interface languages. It also adds a test that fails if any of these labels is missing. The translations are AI-assisted and have not been reviewed by native speakers, so some wording may need refinement. This does not affect functionality, and the change is low risk to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: adding fill-handle and Home › Fill menu labels to every interface catalog. The raw summary and objectives confirm the PR adds these rows across all 18 non-English cata…
Linked Issues check Passed Issue #4458 requires catalog rows for fill-handle labels. The change adds rows in all 18 non-English catalogs: Copy Cells, Fill Series, Fill Formatting Only, Fill Without Formatting, Fill Days, Fill W…
Out of Scope Changes check Passed All changes map to #4458. They consist of catalog rows in the 18 i18n/*.rs files, a new test in i18n.rs, and a docs/localization-parity.md update that records the new coverage, the Ukrainian fix, and …
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names the main change: adding fill-handle and Home › Fill menu labels to every interface catalog. The raw summary and objectives confirm the PR adds these rows across all 18 non-English catalogs, plus a test and a docs update. The title is specific and matches the changeset.

Full details: Linked Issues check

Explanation

Issue #4458 requires catalog rows for fill-handle labels. The change adds rows in all 18 non-English catalogs: Copy Cells, Fill Series, Fill Formatting Only, Fill Without Formatting, Fill Days, Fill Weekdays, Fill Months, Fill Years, and Auto Fill Options. The summary shows +12 lines in de, es, fr, ko, ru, sr, tr, vi and zh, which matches the nine catalogs that lacked Series…, Down and Up. Those nine catalogs gain these rows. The Ukrainian rows change from English text to translations (uk.rs, +12/-3). Japanese rows go to EXTRA (ja.rs), and the PR description states CORE and DIALOGS keep their key sets. The i18n.rs test (raw summary) checks each non-English catalog for a nonempty, single-line translation distinct from the English key, which matches the issue's request for a test that fails when a row is missing. Limitation: the i18n.rs diff and the test body could not be read (the checkout lacks the changed blobs, and the file read was truncated before the test), so the test's exact key list rests on the summary and PR description.

Full details: Out of Scope Changes check

Explanation

All changes map to #4458. They consist of catalog rows in the 18 i18n/*.rs files, a new test in i18n.rs, and a docs/localization-parity.md update that records the new coverage, the Ukrainian fix, and that translations are AI-assisted and not native-speaker reviewed. Catalog and test changes implement the issue. The documentation change supports the same work and does not alter behavior. No unrelated changes appear in the summary. The i18n.rs diff could not be read, so the test contents are not independently verified.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Clippy (1.99.1)

Clippy execution failed
Clippy (1.99.1) exceeded its 180-second time budget. Findings from completed work are retained; remaining checks are incomplete.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4c388df and 60e9ae0.

Files selected for processing: 20

  • crates/ui-egui/src/i18n.rs
  • crates/ui-egui/src/i18n/cs.rs
  • crates/ui-egui/src/i18n/de.rs
  • crates/ui-egui/src/i18n/el.rs
  • crates/ui-egui/src/i18n/es.rs
  • crates/ui-egui/src/i18n/fr.rs
  • crates/ui-egui/src/i18n/it.rs
  • crates/ui-egui/src/i18n/ja.rs
  • crates/ui-egui/src/i18n/ko.rs
  • crates/ui-egui/src/i18n/nl.rs
  • crates/ui-egui/src/i18n/pl.rs
  • crates/ui-egui/src/i18n/pt.rs
  • crates/ui-egui/src/i18n/ro.rs
  • crates/ui-egui/src/i18n/ru.rs
  • crates/ui-egui/src/i18n/sr.rs
  • crates/ui-egui/src/i18n/tr.rs
  • crates/ui-egui/src/i18n/uk.rs
  • crates/ui-egui/src/i18n/vi.rs
  • crates/ui-egui/src/i18n/zh.rs
  • docs/localization-parity.md

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

rickyb82 added a commit to rickyb82/gridcraft that referenced this pull request Nov 18, 2026
Rows that pull requests open here already add to the Italian table (storytold#1821, storytold#2460, storytold#2880, storytold#3521, storytold#3767, storytold#4459) are taken out of this branch and left to their authors: 275 of the 340 stay. docs/localization-parity.md follows (1,376 entries).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fill-handle menu labels have no rows in any interface catalog

1 participant