Repository navigation
Conversation
…told#4458) The right-drag fill menu and the Auto Fill Options button (Copy Cells, Fill Series, Fill Formatting Only, Fill Without Formatting, Fill Days, Fill Weekdays, Fill Months, Fill Years and the button's own name) had no row in any catalog, so every language showed them in English. Add them to all 18 non-English catalogs, add Series…, Down and Up from the Home › Fill menu to the nine catalogs that lacked them, and translate the Ukrainian rows that held English. fill_menu_labels_are_translated_in_every_catalog fails when one of these rows goes missing or stays English. Fixes storytold#4458 Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Rows that pull requests open here already add to the Italian table (storytold#1821, storytold#2460, storytold#2880, storytold#3521, storytold#3767, storytold#4459) are taken out of this branch and left to their authors: 275 of the 340 stay. docs/localization-parity.md follows (1,376 entries).
Fixes #4458.
The fill-handle menus showed English in every interface language. This adds the missing catalog rows:
Each catalog's existing word for "fill" is kept, e.g. German ausfüllen, Dutch vullen, Romanian Umplere. Japanese adds its rows to
EXTRA, the list for menu and pop-up labels, soCOREandDIALOGSkeep their key sets. The translations were written from the plain meaning of the English. Native speakers haven't reviewed them yet, and their provenance is recorded indocs/localization-parity.md, as for earlier catalog changes.Test.
i18n::tests::fill_menu_labels_are_translated_in_every_catalogchecks that every catalog has a non-empty, single-line, non-English row for each of these labels. It fails without this change (es: no row for "Copy Cells").Ran locally (Linux):
cargo fmt --all -- --checkcargo clippy -p gridcraft-ui-egui --lib --locked -- -D warningscargo test -p gridcraft-ui-egui --lib --locked: 351 passedI didn't run the full
cargo xtask ci(integration tests, wasm), so I'm relying on CI for those.Overlap. A few open catalog PRs add some of these keys to some languages: #2880, #3663, #2647, #2753, #3034, #4134 and #3258. Whichever lands second needs to drop the duplicate rows, or clippy will flag the unreachable match arms. #2628 adds Linear Trend and Growth Trend to the same menu and needs its own rows.
Summary by CodeRabbit