Repository navigation
[Rector] Add PreferGenericTemplateOnSameUnionTypeRule - #349
Merged
Merged
Conversation
This was referenced Oct 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts
PreferGenericTemplateOnSameUnionTypeRulefrom rector-srcutils/phpstaninto this package, under theRules/Rectornamespace and registered inconfig/rector-rules.neon.The rule flags a method whose param and return share the same class-type union, e.g.
(A|B $node): A|B|null. Such a method usually returns the passed node, so a@templategeneric narrows the return to the passed type.Skips methods that already declare a
@template, scalar unions, and mismatched unions.PHP 7.4 compatible - no native union param type,
strpos()instead ofstr_contains().