Repository navigation
Do not auto-register PreferGenericTemplateOnSameUnionTypeRule in rector-rules set - #350
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
…or-rules set The rule is stricter than the rest of the set and flags valid code in sibling packages. Keep the class shippable, but let consumers opt in via their own rules: registration instead of forcing it on every package that includes the rector-rules set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule added in #349 is stricter than the rest of the
rector-rulesset and flags valid code in sibling packages (rector-phpunit etc.) that include the set in their own PHPStan run.Keep the rule class shippable, but remove it from the auto-registered set. Consumers opt in via their own
rules:registration instead of having it forced on every package that includesrector-rules.neon.